Bug 7503 - Make kxmlcore/Assertions.cpp portable
Summary: Make kxmlcore/Assertions.cpp portable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 420+
Hardware: Macintosh OS X 10.4
: P4 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-27 19:41 PST by Eric Seidel (no email)
Modified: 2006-02-27 20:42 PST (History)
0 users

See Also:


Attachments
make assertions.cpp portable (22.66 KB, patch)
2006-02-27 19:42 PST, Eric Seidel (no email)
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2006-02-27 19:41:27 PST
Make kxmlcore/Assertions.cpp portable.

This file had a bunch of Obj-c goop in it.  I removed it.  Pushed the mac specific logic up into WebCore.

I tested this patch by setting my WebCoreLogLevel:

defaults write com.apple.Safari WebCoreLogLevel 0xFFFFF

then launching safari, and watching logs spew to the console.  I know next-to-nothing about the logging mechanisms, but it seemed to be working.
Comment 1 Eric Seidel (no email) 2006-02-27 19:42:19 PST
Created attachment 6765 [details]
make assertions.cpp portable