Bug 75025

Summary:

ManualTests HTML template should be simplified

Product:

WebKit

Reporter:

Daniel Jalkut <jalkut>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ap, darin, ojan, rniwa, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch for the recommended changes to the template file	none

Description Daniel Jalkut 2011-12-21 12:00:03 PST

During review for my patch in bug 74775, Ryosuke Niwa suggested some edits to the ManualTests HTML, which had originated in template.html.

https://bugs.webkit.org/show_bug.cgi?id=74775#c9

Specifically, to use an HTML5 style doctype and opening block, and to remove the empty head section.

Comment 1 Daniel Jalkut 2011-12-21 12:01:41 PST

Created attachment 120208 [details]
Patch for the recommended changes to the template file

Comment 2 Ryosuke Niwa 2011-12-21 12:04:44 PST

Could you set r? and cq? flags? They indicate that the patch is up for review and you want it be landed respectively.

Comment 3 Daniel Jalkut 2011-12-21 12:15:32 PST

(In reply to comment #2)
> Could you set r? and cq? flags? They indicate that the patch is up for review and you want it be landed respectively.

To set those flags after the fact do I essentially have to re-attach and obsolete?

Comment 4 Daniel Jalkut 2011-12-21 12:16:11 PST

Comment on attachment 120208 [details]
Patch for the recommended changes to the template file 

Add review and commit-queue flags

Comment 5 WebKit Review Bot 2011-12-22 02:23:58 PST

Comment on attachment 120208 [details]
Patch for the recommended changes to the template file 

Clearing flags on attachment: 120208

Committed r103508: <http://trac.webkit.org/changeset/103508>

Comment 6 WebKit Review Bot 2011-12-22 02:24:02 PST

All reviewed patches have been landed.  Closing bug.