Bug 74996

Summary:

[Forms] Add OVERRIDE to WebCore/html/*InputType.h

Product:

WebKit

Reporter:

yosin

Component:

Forms

Assignee:

yosin

Status:

RESOLVED FIXED

Severity:

Normal

CC:

tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch 1	none

yosin

Reported 2011-12-20 23:04:07 PST

We would like to have "override" method modifier (by using OVERRIDE macro) for WebCore/html/*InputType.h to make our code robust. There are 30 files: 1 BaseButtonInputType.h 2 BaseCheckableInputType.h 3 BaseDateAndTimeInputType.h 4 BaseTextInputType.h 5 ButtonInputType.h 6 CheckboxInputType.h 7 ColorInputType.h 8 DateInputType.h 9 DateTimeInputType.h 10 DateTimeLocalInputType.h 11 EmailInputType.h 12 FileInputType.h 13 HiddenInputType.h 14 ImageInputType.h 15 InputType.h 16 IsIndexInputType.h 17 MonthInputType.h 18 NumberInputType.h 19 PasswordInputType.h 20 RadioInputType.h 21 RangeInputType.h 22 ResetInputType.h 23 SearchInputType.h 24 SubmitInputType.h 25 TelephoneInputType.h 26 TextFieldInputType.h 27 TextInputType.h 28 TimeInputType.h 29 URLInputType.h 30 WeekInputType.h

Attachments
Patch 1 (50.57 KB, patch) 2011-12-21 00:10 PST, yosin	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

yosin

Comment 1 2011-12-21 00:10:13 PST

Created attachment 120153 [details] Patch 1

Kent Tamura

Comment 2 2011-12-21 00:27:27 PST

Comment on attachment 120153 [details] Patch 1 ok

WebKit Review Bot

Comment 3 2011-12-21 01:48:02 PST

Comment on attachment 120153 [details] Patch 1 Clearing flags on attachment: 120153 Committed r103400: <http://trac.webkit.org/changeset/103400>

WebKit Review Bot

Comment 4 2011-12-21 01:48:06 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.