Bug 74980

Summary: Leak of WebNotificationClient when page is destroyed
Product: WebKit Reporter: Jon Lee <jonlee>
Component: New BugsAssignee: Jon Lee <jonlee>
Status: RESOLVED FIXED    
Severity: Normal CC: rakuco, webkit-bug-importer, webkit.review.bot
Priority: P1 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch mrowe: review+

Jon Lee
Reported 2011-12-20 17:19:00 PST
When the page is destroyed the notification controller does not tell the client that it is being destroyed. The client gets leaked.
Attachments
Patch (17.11 KB, patch)
2012-01-03 14:32 PST, Jon Lee 		mrowe: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2011-12-20 17:19:32 PST
<rdar://problem/10611231>
Jon Lee
Comment 2 2012-01-03 14:32:18 PST
Created attachment 120999 [details] Patch
Mark Rowe (bdash)
Comment 3 2012-01-03 14:48:39 PST
Comment on attachment 120999 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120999&action=review It may be worth adding comments to the ChangeLogs for the ports that are getting empty implementations of the new client method briefly mentioning why they're empty rather than doing what WebKit/mac and WebKit2 are doing (different ownership model for the Client object presumably?). > Source/WebCore/ChangeLog:3 > + [WK2] Leak of WebNotificationClient when page is destroyed Seems like the [WK2] should be removed since it appears to also leak on WebKit1 for Mac.
Jon Lee
Comment 4 2012-01-03 14:57:42 PST
Will do. Thanks for the review.
Jon Lee
Comment 5 2012-01-03 15:28:21 PST
Commited r103975: http://trac.webkit.org/changeset/103975
Note You need to log in before you can comment on or make changes to this bug.