Summary: | Leak of WebNotificationClient when page is destroyed | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jon Lee <jonlee> | ||||
Component: | New Bugs | Assignee: | Jon Lee <jonlee> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | rakuco, webkit-bug-importer, webkit.review.bot | ||||
Priority: | P1 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Jon Lee
2011-12-20 17:19:00 PST
Created attachment 120999 [details]
Patch
Comment on attachment 120999 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120999&action=review It may be worth adding comments to the ChangeLogs for the ports that are getting empty implementations of the new client method briefly mentioning why they're empty rather than doing what WebKit/mac and WebKit2 are doing (different ownership model for the Client object presumably?). > Source/WebCore/ChangeLog:3 > + [WK2] Leak of WebNotificationClient when page is destroyed Seems like the [WK2] should be removed since it appears to also leak on WebKit1 for Mac. Will do. Thanks for the review. |