Bug 74954

Summary:

Web Inspector: CodeGeneratorInspector.py: generate enum types.

Product:

WebKit

Reporter:

Peter Rybin <peter.rybin>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, dglazkov, gustavo, joepeck, keishi, loislo, peter.rybin, pfeldman, pmuellr, rik, webkit.review.bot, xan.lopez, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

72861, 75307

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Sample InspectorFrontend.h	none
Sample InspectorFrontend.cpp	none
Patch	none
Patch	none
For win trybot	none
Patch	none
Sample InspectorFrontend.h	none
For win trybot	none
For win trybot	none
For trybots	none
InspectorFrontend.h base version	none
InspectorFrontend.cpp base version	none
Patch	none
New InspectorFrontend.h	none
New InspectorFrontend.cpp	none
Generator output diff	none
Patch	none
New InspectorFrontend.h	none
New InspectorFrontend.cpp	none
Generator output diff	none
Same patch to test it on Mac bot	none

Peter Rybin

Reported 2011-12-20 14:05:45 PST

Generate enum types in C++ TypeBuilder. As we discussed with caseq@, JSON enums are morphed into C++ enums with its numeric values pointing to an actual string value in pre-build array. This also requires setter methods to become overloaded so that both old string-based and new enum-based code styles could co-exist.

Attachments
Patch (17.06 KB, patch) 2011-12-22 10:55 PST, Peter Rybin	no flags	Details Formatted Diff Diff
Sample InspectorFrontend.h (140.48 KB, text/plain) 2011-12-22 10:57 PST, Peter Rybin	no flags	Details
Sample InspectorFrontend.cpp (38.84 KB, text/plain) 2011-12-22 10:58 PST, Peter Rybin	no flags	Details
Patch (18.77 KB, patch) 2011-12-22 11:49 PST, Peter Rybin	no flags	Details Formatted Diff Diff
Patch (20.64 KB, patch) 2011-12-22 12:57 PST, Peter Rybin	no flags	Details Formatted Diff Diff
For win trybot (20.71 KB, patch) 2011-12-23 04:16 PST, Peter Rybin	no flags	Details Formatted Diff Diff
Patch (16.79 KB, patch) 2011-12-23 05:18 PST, Peter Rybin	no flags	Details Formatted Diff Diff
Sample InspectorFrontend.h (140.21 KB, text/plain) 2011-12-23 05:20 PST, Peter Rybin	no flags	Details
For win trybot (16.80 KB, patch) 2011-12-23 05:58 PST, Peter Rybin	no flags	Details Formatted Diff Diff
For win trybot (16.85 KB, patch) 2011-12-23 07:47 PST, Peter Rybin	no flags	Details Formatted Diff Diff
For trybots (19.59 KB, patch) 2011-12-27 09:41 PST, Peter Rybin	no flags	Details Formatted Diff Diff
InspectorFrontend.h base version (138.72 KB, text/plain) 2011-12-27 10:03 PST, Peter Rybin	no flags	Details
InspectorFrontend.cpp base version (37.70 KB, text/plain) 2011-12-27 10:04 PST, Peter Rybin	no flags	Details
Patch (17.29 KB, patch) 2011-12-27 10:25 PST, Peter Rybin	no flags	Details Formatted Diff Diff
New InspectorFrontend.h (140.51 KB, text/plain) 2011-12-27 10:26 PST, Peter Rybin	no flags	Details
New InspectorFrontend.cpp (38.84 KB, text/plain) 2011-12-27 10:28 PST, Peter Rybin	no flags	Details
Generator output diff (14.26 KB, text/plain) 2011-12-27 10:31 PST, Peter Rybin	no flags	Details
Patch (17.28 KB, patch) 2011-12-28 08:18 PST, Peter Rybin	no flags	Details Formatted Diff Diff
New InspectorFrontend.h (140.50 KB, text/plain) 2011-12-28 08:25 PST, Peter Rybin	no flags	Details
New InspectorFrontend.cpp (38.84 KB, text/plain) 2011-12-28 08:26 PST, Peter Rybin	no flags	Details
Generator output diff (14.25 KB, text/plain) 2011-12-28 08:27 PST, Peter Rybin	no flags	Details
Same patch to test it on Mac bot (17.28 KB, patch) 2011-12-28 08:35 PST, Yury Semikhatsky	no flags	Details Formatted Diff Diff
Show Obsolete (16) View All Add attachment proposed patch, testcase, etc.

Peter Rybin

Comment 1 2011-12-22 10:55:31 PST

Created attachment 120340 [details] Patch

Peter Rybin

Comment 2 2011-12-22 10:57:29 PST

Created attachment 120341 [details] Sample InspectorFrontend.h

Peter Rybin

Comment 3 2011-12-22 10:58:32 PST

Created attachment 120342 [details] Sample InspectorFrontend.cpp

Peter Rybin

Comment 4 2011-12-22 11:49:28 PST

Created attachment 120356 [details] Patch

Gyuyoung Kim

Comment 5 2011-12-22 12:12:31 PST

Comment on attachment 120356 [details] Patch Attachment 120356 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10997623

Early Warning System Bot

Comment 6 2011-12-22 12:18:15 PST

Comment on attachment 120356 [details] Patch Attachment 120356 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10997627

WebKit Review Bot

Comment 7 2011-12-22 12:22:44 PST

Comment on attachment 120356 [details] Patch Attachment 120356 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11001595

Gustavo Noronha (kov)

Comment 8 2011-12-22 12:35:00 PST

Comment on attachment 120356 [details] Patch Attachment 120356 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10997636

Peter Rybin

Comment 9 2011-12-22 12:57:09 PST

Created attachment 120367 [details] Patch

Peter Rybin

Comment 10 2011-12-23 04:16:50 PST

Created attachment 120456 [details] For win trybot

Peter Rybin

Comment 11 2011-12-23 05:18:50 PST

Created attachment 120460 [details] Patch

Peter Rybin

Comment 12 2011-12-23 05:20:11 PST

Created attachment 120461 [details] Sample InspectorFrontend.h

Peter Rybin

Comment 13 2011-12-23 05:58:28 PST

Created attachment 120463 [details] For win trybot

Peter Rybin

Comment 14 2011-12-23 07:47:40 PST

Created attachment 120465 [details] For win trybot

Ilya Tikhonovsky

Comment 15 2011-12-23 08:14:31 PST

I'd like to see enum constants declared as CamelCase according to WebKit style guide. Rule Names:12. Enum members should user InterCaps with an initial capital letter. If it is not possible then I prefer the chromium style kCamelCase

Peter Rybin

Comment 16 2011-12-27 09:41:48 PST

Created attachment 120595 [details] For trybots

Peter Rybin

Comment 17 2011-12-27 10:03:20 PST

Created attachment 120599 [details] InspectorFrontend.h base version

Peter Rybin

Comment 18 2011-12-27 10:04:28 PST

Created attachment 120600 [details] InspectorFrontend.cpp base version

Peter Rybin

Comment 19 2011-12-27 10:25:27 PST

Created attachment 120601 [details] Patch

Peter Rybin

Comment 20 2011-12-27 10:26:43 PST

Created attachment 120602 [details] New InspectorFrontend.h

Peter Rybin

Comment 21 2011-12-27 10:28:19 PST

Created attachment 120603 [details] New InspectorFrontend.cpp

Peter Rybin

Comment 22 2011-12-27 10:31:36 PST

Created attachment 120604 [details] Generator output diff

Yury Semikhatsky

Comment 23 2011-12-27 11:28:36 PST

Comment on attachment 120601 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120601&action=review > Source/WebCore/inspector/CodeGeneratorInspector.py:54 > + "": "Empty", Please change this to some non-empty constant ("regular" should be find for CSSRule.origin as we discussed offline) or file a bug about this.

Yury Semikhatsky

Comment 24 2011-12-28 05:29:47 PST

Comment on attachment 120601 [details] Patch Clearing flags on attachment: 120601 Committed r103763: <http://trac.webkit.org/changeset/103763>

Yury Semikhatsky

Comment 25 2011-12-28 05:30:02 PST

All reviewed patches have been landed. Closing bug.

Yury Semikhatsky

Comment 26 2011-12-28 06:58:18 PST

Reopening since the patch was rolled out in https://bugs.webkit.org/show_bug.cgi?id=75307 due to Mac compile failures.

Peter Rybin

Comment 27 2011-12-28 08:18:52 PST

Created attachment 120671 [details] Patch

Peter Rybin

Comment 28 2011-12-28 08:25:27 PST

Created attachment 120673 [details] New InspectorFrontend.h

Peter Rybin

Comment 29 2011-12-28 08:26:03 PST

Created attachment 120674 [details] New InspectorFrontend.cpp

Peter Rybin

Comment 30 2011-12-28 08:27:32 PST

Created attachment 120675 [details] Generator output diff

Yury Semikhatsky

Comment 31 2011-12-28 08:35:04 PST

Created attachment 120676 [details] Same patch to test it on Mac bot

Yury Semikhatsky

Comment 32 2012-01-11 06:18:00 PST

Comment on attachment 120671 [details] Patch Clearing flags on attachment: 120671 Committed r104707: <http://trac.webkit.org/changeset/104707>

Yury Semikhatsky

Comment 33 2012-01-11 06:18:27 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.