| Summary: | IndexedDB: Add tests for structured clone data | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joshua Bell <jsbell> | ||||||||||||||||||||||||
| Component: | New Bugs | Assignee: | Joshua Bell <jsbell> | ||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||
| Severity: | Normal | CC: | dglazkov, dgrogan, tony, webkit.review.bot | ||||||||||||||||||||||||
| Priority: | P2 | ||||||||||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||||||||||
| Bug Blocks: | 77239 | ||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||
|
Description
Joshua Bell
2011-12-19 16:15:07 PST
Created attachment 119940 [details]
Patch
Comment on attachment 119940 [details]
Patch
WIP, no review yet
Created attachment 119957 [details]
Patch
Comment on attachment 119957 [details]
Patch
Added File test (name is lost) but still WIP
Created attachment 121525 [details]
Patch
Created attachment 121526 [details]
Patch
Tests only - review? Note one FAIL in the expectations file - the V8 serialized cloning code doesn't distinguish 0 and -0. It should, but will require checking around to see where folks think the test should live (should -0 be considered a non-Integer, or should the SSV code special case it?) Comment on attachment 121526 [details] Patch Attachment 121526 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11172177 New failing tests: storage/indexeddb/structured-clone.html Created attachment 121707 [details]
Patch
New patch. Removed some FIXMEs, clarified others with bug URL, removed debug lines that depended on a file modification time (duh) that would have caused failures. Comment on attachment 121707 [details] Patch Attachment 121707 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11184652 New failing tests: storage/indexeddb/structured-clone.html No idea why this is failing - it passes when submitted to linux_layout try bot. May have to bisect the test. :P Created attachment 123210 [details]
Patch
Marked test as failing (TEXT) in expectations. This should let it pass cr-linux (Chromium EWS). Per offline discussion, we can then land this harmlessly and determine what the text difference actually is since it doesn't repro locally or via the try bots. Comment on attachment 123210 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123210&action=review LGTM I didn't go through this finely. > LayoutTests/storage/indexeddb/structured-clone.html:16 > +if (window.eventSender) { What's this? When is it available and not available? (In reply to comment #15) > > LayoutTests/storage/indexeddb/structured-clone.html:16 > > +if (window.eventSender) { > > What's this? When is it available and not available? It's used in other layout tests to synthesize drag & drop events (which is what I'm using it for here, to produce the data for File and FileList tests). I admit I just copied&pasted from other tests - it looks like it's provided by DumpRenderTree in Tools/DumpRenderTree/$PORT/EventSender.cpp http://crbug.com/108012 reports a crash when storing File objects in the Chromium port. Possible that this is what we're seeing here. Comment on attachment 123210 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123210&action=review > LayoutTests/platform/chromium/test_expectations.txt:3921 > +BUGWK74897 : storage/indexeddb/structured-clone.html = TEXT You may want to file a new bug to track this since landing this patch will close 74897. >> LayoutTests/storage/indexeddb/structured-clone.html:16 >> +if (window.eventSender) { > > What's this? When is it available and not available? It's like window.layoutTestController. Checking it for existence is nice when loading in a regular browser rather than DumpRenderTree. > LayoutTests/storage/indexeddb/structured-clone.html:23 > + eventSender.beginDragWithFiles(['resources/test-data.html', 'resources/test-data.txt']); > + eventSender.mouseMoveTo(targetX, targetY); > + eventSender.mouseUp(); Nit: Can you add some text (maybe to the description) that says that this test requires DumpRenderTree? Alternately you could write instructions on how to run the test from a browser. Created attachment 124227 [details]
Patch
Comment on attachment 124227 [details] Patch Attachment 124227 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11350571 New failing tests: storage/indexeddb/structured-clone.html Yay, looks like it was other tests that failed cr-linux (Chromium EWS), not this one. I'll re-up the patch; not going to land until I get a green. Created attachment 124348 [details]
Patch
Comment on attachment 124348 [details]
Patch
No changes, just running through cq prechecks again.
Comment on attachment 124348 [details] Patch Attachment 124348 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11350838 New failing tests: storage/indexeddb/structured-clone.html Created attachment 124359 [details]
Patch
Okay, tony@ - for real this time? Comment on attachment 124359 [details] Patch Rejecting attachment 124359 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: unk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej patching file LayoutTests/storage/indexeddb/resources/test-data.html patching file LayoutTests/storage/indexeddb/resources/test-data.txt patching file LayoutTests/storage/indexeddb/structured-clone-expected.txt patching file LayoutTests/storage/indexeddb/structured-clone.html Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Tony Chang']" exit_code: 1 Full output: http://queues.webkit.org/results/11371235 Created attachment 124574 [details]
Patch for landing
Comment on attachment 124574 [details] Patch for landing Rejecting attachment 124574 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: 1 FAILED at 4038. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej patching file LayoutTests/storage/indexeddb/resources/test-data.html patching file LayoutTests/storage/indexeddb/resources/test-data.txt patching file LayoutTests/storage/indexeddb/structured-clone-expected.txt patching file LayoutTests/storage/indexeddb/structured-clone.html Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/11368619 Created attachment 124579 [details]
Patch for landing
Comment on attachment 124579 [details] Patch for landing Clearing flags on attachment: 124579 Committed r106279: <http://trac.webkit.org/changeset/106279> All reviewed patches have been landed. Closing bug. |