Bug 74852

Summary: [Qt][WK2] Add support for modal event loop processing for WTR
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: New BugsAssignee: Simon Hausmann <hausmann>
Status: RESOLVED FIXED    
Severity: Normal CC: kbalazs, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Simon Hausmann
Reported 2011-12-19 03:50:05 PST
[Qt][WK2] Add support for modal event loop processing for WTR
Attachments
Patch (8.03 KB, patch)
2011-12-19 04:00 PST, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
Patch (8.18 KB, patch)
2011-12-19 04:08 PST, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
Patch (4.98 KB, patch)
2012-11-09 08:57 PST, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2011-12-19 03:52:10 PST
Lack of support causes fast/animation/request-animation-frame-during-modal.html to fail with Qt/WK2 right now
Simon Hausmann
Comment 2 2011-12-19 04:00:02 PST
Created attachment 119844 [details] Patch
Simon Hausmann
Comment 3 2011-12-19 04:08:42 PST
Created attachment 119845 [details] Patch Updated patch that fixes build issue with moc file inclusion
Kenneth Rohde Christiansen
Comment 4 2011-12-19 04:14:01 PST
Comment on attachment 119845 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119845&action=review > Source/WebKit2/Platform/qt/RunLoopQt.cpp:65 > + static bool mainEventLoopRunning = false; IsRunning? > Source/WebKit2/Platform/qt/RunLoopQt.cpp:73 > + QEventLoop* oldCurrent = currentEventLoop; old current sounds strange
Simon Hausmann
Comment 5 2011-12-19 04:23:26 PST
Comment on attachment 119845 [details] Patch Thanks for the review. Will rename the variables before landing.
Simon Hausmann
Comment 6 2011-12-19 04:34:23 PST
Committed r103228: <http://trac.webkit.org/changeset/103228>
Balazs Kelemen
Comment 7 2012-11-09 08:57:28 PST
Reopening to attach new patch.
Balazs Kelemen
Comment 8 2012-11-09 08:57:31 PST
Created attachment 173316 [details] Patch
Balazs Kelemen
Comment 9 2012-11-12 02:45:46 PST
Comment on attachment 173316 [details] Patch Oops, sorry, wrong bug.
Note You need to log in before you can comment on or make changes to this bug.