Summary: | [CSS Shaders] Follow up bug to fix issues mentioned in comment 23 from bug 73317 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexandru Chiculita <achicu> | ||||||
Component: | Layout and Rendering | Assignee: | Alexandru Chiculita <achicu> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cmarrin, dino, japhet, macpherson, webkit.review.bot, zimmermann | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 73317 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Alexandru Chiculita
2011-12-18 23:36:00 PST
Created attachment 120014 [details]
Patch V1
The spec seems to have been updated to use 1 by 1 as the default mesh. I've also updated that and added some comments.
Created attachment 120018 [details]
Patch V2
Using the StringBuilder only inside the CachedShader.cpp file.
Comment on attachment 120018 [details] Patch V2 View in context: https://bugs.webkit.org/attachment.cgi?id=120018&action=review Much nicer, thanks a lot. r=me with a few comments: > Source/WebCore/platform/graphics/filters/CustomFilterShader.cpp:51 > +const char* CustomFilterShader::defaultFragmentShaderString = > + "precision mediump float;\n" \ I admit, I like the other solution much more now :-) It's much more readable, would you mind updating it once again? > Source/WebCore/platform/graphics/filters/CustomFilterShader.h:79 > + static const char* defaultVertexShaderString; > + static const char* defaultFragmentShaderString; This could be removed again using this SHADER technique. |