Bug 74838

Summary: Enable <track> for Mac build
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: joepeck, sam, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch darin: review+

Eric Carlson
Reported 2011-12-18 23:03:17 PST
Define ENABLE_VIDEO_TRACK and initialize the runtime feature to true;
Attachments
Proposed patch (2.83 KB, patch)
2011-12-18 23:04 PST, Eric Carlson 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2011-12-18 23:04:01 PST
Created attachment 119821 [details] Proposed patch
WebKit Review Bot
Comment 2 2011-12-18 23:05:22 PST
Attachment 119821 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/wtf/Platform.h', u'S..." exit_code: 1 Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:177: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 3 2011-12-18 23:10:46 PST
Comment on attachment 119821 [details] Proposed patch No change log here. Turning this on is fine.
Eric Carlson
Comment 4 2011-12-19 07:59:50 PST
http://trac.webkit.org/changeset/103240
Joseph Pecoraro
Comment 5 2012-01-06 16:42:58 PST
The FeatureDefines files are normally identical across all Mac projects (JSC, WC, WK, WK2). This patch missed JavaScriptCore's FeatureDefines file but modified all the others, and modified Platform.h. Is the JSC diff necessary or was that just missed by accident?
Radar WebKit Bug Importer
Comment 6 2012-01-06 16:43:20 PST
<rdar://problem/10658329>
Note You need to log in before you can comment on or make changes to this bug.