| Summary: | Update dropzone implementation per spec update | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yael <yael> | ||||||||
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ojan, tony, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Yael
2011-12-18 19:22:24 PST
Created attachment 119802 [details]
Patch
Update support for dropzone attribute to use file: and string: instead of f: and s:.
Comment on attachment 119802 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119802&action=review > Source/WebCore/ChangeLog:11 > + Update support for dropzone attribute to use file: and string: instead of f: and s:. > + > + No new tests. Existing tests over this and were updated. > + Maybe you should say what spec this is part of? Created attachment 119858 [details]
Patch.
Added link to the spec.
Comment on attachment 119858 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=119858&action=review > Source/WebCore/dom/Clipboard.cpp:213 > + if (keyword.length() > 5 && keyword.startsWith("file:")) Nit: startsWith will check the length for you so you can remove the length() > 5 check. > Source/WebCore/dom/Clipboard.cpp:216 > + if (keyword.length() > 7 && keyword.startsWith("string:")) Remove the length() > 7 check. Created attachment 119942 [details]
Patch for landing
Thanks for the review, Tony :)
Comment on attachment 119942 [details] Patch for landing Clearing flags on attachment: 119942 Committed r103303: <http://trac.webkit.org/changeset/103303> All reviewed patches have been landed. Closing bug. |