Bug 74834

Summary:

Update dropzone implementation per spec update

Product:

WebKit

Reporter:

Yael <yael>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ojan, tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch.	tony: review+, tony: commit-queue-
Patch for landing	none

Yael

Reported 2011-12-18 19:22:24 PST

Per https://bugs.webkit.org/show_bug.cgi?id=58210#c43 the spec has changed, so the webkit implementation needs an update.

Attachments
Patch (4.84 KB, patch) 2011-12-18 19:32 PST, Yael	no flags	Details Formatted Diff Diff
Patch. (4.92 KB, patch) 2011-12-19 06:34 PST, Yael	tony: review+ tony: commit-queue-	Details Formatted Diff Diff
Patch for landing (4.87 KB, patch) 2011-12-19 16:20 PST, Yael	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Yael

Comment 1 2011-12-18 19:32:43 PST

Created attachment 119802 [details] Patch Update support for dropzone attribute to use file: and string: instead of f: and s:.

Kenneth Rohde Christiansen

Comment 2 2011-12-19 01:02:41 PST

Comment on attachment 119802 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119802&action=review > Source/WebCore/ChangeLog:11 > + Update support for dropzone attribute to use file: and string: instead of f: and s:. > + > + No new tests. Existing tests over this and were updated. > + Maybe you should say what spec this is part of?

Yael

Comment 3 2011-12-19 06:34:28 PST

Created attachment 119858 [details] Patch. Added link to the spec.

Tony Chang

Comment 4 2011-12-19 10:25:17 PST

Comment on attachment 119858 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=119858&action=review > Source/WebCore/dom/Clipboard.cpp:213 > + if (keyword.length() > 5 && keyword.startsWith("file:")) Nit: startsWith will check the length for you so you can remove the length() > 5 check. > Source/WebCore/dom/Clipboard.cpp:216 > + if (keyword.length() > 7 && keyword.startsWith("string:")) Remove the length() > 7 check.

Yael

Comment 5 2011-12-19 16:20:22 PST

Created attachment 119942 [details] Patch for landing Thanks for the review, Tony :)

WebKit Review Bot

Comment 6 2011-12-19 21:27:14 PST

Comment on attachment 119942 [details] Patch for landing Clearing flags on attachment: 119942 Committed r103303: <http://trac.webkit.org/changeset/103303>

WebKit Review Bot

Comment 7 2011-12-19 21:27:18 PST

All reviewed patches have been landed. Closing bug.

Tony Chang

Comment 8 2012-01-03 14:21:50 PST

*** Bug 75495 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.