Bug 74831

Summary: More PlatformEvent cleanup
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, gustavo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch mitz: review+, webkit-ews: commit-queue-

Description Sam Weinig 2011-12-18 18:41:58 PST 
More PlatformEvent cleanup
Comment 1 Sam Weinig 2011-12-18 18:44:33 PST 
Created attachment 119798 [details]
Patch
Comment 2 Early Warning System Bot 2011-12-18 18:54:59 PST 
Comment on attachment 119798 [details]
Patch

Attachment 119798 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10935369
Comment 3 WebKit Review Bot 2011-12-18 19:07:33 PST 
Comment on attachment 119798 [details]
Patch

Attachment 119798 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10935373
Comment 4 Gustavo Noronha (kov) 2011-12-18 21:17:15 PST 
Comment on attachment 119798 [details]
Patch

Attachment 119798 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10935401
Comment 5 Sam Weinig 2011-12-19 16:30:40 PST 
Created attachment 119945 [details]
Patch
Comment 6 WebKit Review Bot 2011-12-19 16:32:34 PST 
Attachment 119945 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit/win/WebView.cpp:1468:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 1 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Early Warning System Bot 2011-12-19 16:53:08 PST 
Comment on attachment 119945 [details]
Patch

Attachment 119945 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10927119
Comment 8 Sam Weinig 2011-12-19 17:21:24 PST 
Created attachment 119958 [details]
Patch
Comment 9 WebKit Review Bot 2011-12-19 17:24:14 PST 
Attachment 119958 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit/win/WebView.cpp:1468:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 1 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Early Warning System Bot 2011-12-19 18:10:26 PST 
Comment on attachment 119958 [details]
Patch

Attachment 119958 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10966116
Comment 11 Gustavo Noronha (kov) 2011-12-19 19:17:15 PST 
Comment on attachment 119958 [details]
Patch

Attachment 119958 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10967247
Comment 12 Sam Weinig 2011-12-19 20:08:30 PST 
Committed r103297: <http://trac.webkit.org/changeset/103297>