Bug 74831

Summary: More PlatformEvent cleanup
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, gustavo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch mitz: review+, webkit-ews: commit-queue-

Sam Weinig
Reported 2011-12-18 18:41:58 PST
More PlatformEvent cleanup
Attachments
Patch (20.12 KB, patch)
2011-12-18 18:44 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (40.11 KB, patch)
2011-12-19 16:30 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (39.08 KB, patch)
2011-12-19 17:21 PST, Sam Weinig 		mitz: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2011-12-18 18:44:33 PST
Created attachment 119798 [details] Patch
Early Warning System Bot
Comment 2 2011-12-18 18:54:59 PST
Comment on attachment 119798 [details] Patch Attachment 119798 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10935369
WebKit Review Bot
Comment 3 2011-12-18 19:07:33 PST
Comment on attachment 119798 [details] Patch Attachment 119798 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10935373
Gustavo Noronha (kov)
Comment 4 2011-12-18 21:17:15 PST
Comment on attachment 119798 [details] Patch Attachment 119798 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10935401
Sam Weinig
Comment 5 2011-12-19 16:30:40 PST
Created attachment 119945 [details] Patch
WebKit Review Bot
Comment 6 2011-12-19 16:32:34 PST
Attachment 119945 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit/win/WebView.cpp:1468: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 1 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 7 2011-12-19 16:53:08 PST
Comment on attachment 119945 [details] Patch Attachment 119945 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10927119
Sam Weinig
Comment 8 2011-12-19 17:21:24 PST
Created attachment 119958 [details] Patch
WebKit Review Bot
Comment 9 2011-12-19 17:24:14 PST
Attachment 119958 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit/win/WebView.cpp:1468: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 1 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 10 2011-12-19 18:10:26 PST
Comment on attachment 119958 [details] Patch Attachment 119958 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10966116
Gustavo Noronha (kov)
Comment 11 2011-12-19 19:17:15 PST
Comment on attachment 119958 [details] Patch Attachment 119958 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10967247
Sam Weinig
Comment 12 2011-12-19 20:08:30 PST
Committed r103297: <http://trac.webkit.org/changeset/103297>
Note You need to log in before you can comment on or make changes to this bug.