Bug 74831 - More PlatformEvent cleanup
: More PlatformEvent cleanup
Status: RESOLVED FIXED
: WebKit
New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-12-18 18:41 PST by
Modified: 2011-12-19 20:08 PST (History)


Attachments
Patch (20.12 KB, patch)
2011-12-18 18:44 PST, Sam Weinig
no flags Review Patch | Details | Formatted Diff | Diff
Patch (40.11 KB, patch)
2011-12-19 16:30 PST, Sam Weinig
no flags Review Patch | Details | Formatted Diff | Diff
Patch (39.08 KB, patch)
2011-12-19 17:21 PST, Sam Weinig
mitz: review+
webkit-ews: commit‑queue-
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-12-18 18:41:58 PST
More PlatformEvent cleanup
------- Comment #1 From 2011-12-18 18:44:33 PST -------
Created an attachment (id=119798) [details]
Patch
------- Comment #2 From 2011-12-18 18:54:59 PST -------
(From update of attachment 119798 [details])
Attachment 119798 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10935369
------- Comment #3 From 2011-12-18 19:07:33 PST -------
(From update of attachment 119798 [details])
Attachment 119798 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10935373
------- Comment #4 From 2011-12-18 21:17:15 PST -------
(From update of attachment 119798 [details])
Attachment 119798 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10935401
------- Comment #5 From 2011-12-19 16:30:40 PST -------
Created an attachment (id=119945) [details]
Patch
------- Comment #6 From 2011-12-19 16:32:34 PST -------
Attachment 119945 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit/win/WebView.cpp:1468:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 1 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.
------- Comment #7 From 2011-12-19 16:53:08 PST -------
(From update of attachment 119945 [details])
Attachment 119945 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10927119
------- Comment #8 From 2011-12-19 17:21:24 PST -------
Created an attachment (id=119958) [details]
Patch
------- Comment #9 From 2011-12-19 17:24:14 PST -------
Attachment 119958 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit/win/WebView.cpp:1468:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 1 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.
------- Comment #10 From 2011-12-19 18:10:26 PST -------
(From update of attachment 119958 [details])
Attachment 119958 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10966116
------- Comment #11 From 2011-12-19 19:17:15 PST -------
(From update of attachment 119958 [details])
Attachment 119958 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10967247
------- Comment #12 From 2011-12-19 20:08:30 PST -------
Committed r103297: <http://trac.webkit.org/changeset/103297>