Bug 74827

Summary:

KURL::protocolIs() should handle 8-bit strings.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

WebCore Misc.

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

74832

Bug Blocks:

Attachments:

Description	Flags
Patch	koivisto: review+

Andreas Kling

Reported 2011-12-18 17:02:14 PST

We're unnecessarily converting to 16-bit strings here.

Attachments
Patch (2.81 KB, patch) 2011-12-18 17:20 PST, Andreas Kling	koivisto: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2011-12-18 17:20:53 PST

Created attachment 119790 [details] Patch

Darin Adler

Comment 2 2011-12-18 17:39:44 PST

Comment on attachment 119790 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119790&action=review > Source/WebCore/platform/KURL.cpp:1718 > +bool charactersAreProtocol(const CharType* url, const char* protocol) This should have static on it for the same reason that isLetterMatchIgnoringCase does.

Andreas Kling

Comment 3 2011-12-18 17:40:35 PST

Committed r103199: <http://trac.webkit.org/changeset/103199>

Andreas Kling

Comment 4 2011-12-18 17:48:53 PST

(In reply to comment #2) > (From update of attachment 119790 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=119790&action=review > > > Source/WebCore/platform/KURL.cpp:1718 > > +bool charactersAreProtocol(const CharType* url, const char* protocol) > > This should have static on it for the same reason that isLetterMatchIgnoringCase does. Can I take that as an rs=you to add it?

Darin Adler

Comment 5 2011-12-18 17:50:36 PST

Yes.

Note You need to log in before you can comment on or make changes to this bug.