| Summary: | KURL::protocolIs() should handle 8-bit strings. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||
| Component: | WebCore Misc. | Assignee: | Andreas Kling <kling> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 74832 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Andreas Kling
2011-12-18 17:02:14 PST
Created attachment 119790 [details]
Patch
Comment on attachment 119790 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119790&action=review > Source/WebCore/platform/KURL.cpp:1718 > +bool charactersAreProtocol(const CharType* url, const char* protocol) This should have static on it for the same reason that isLetterMatchIgnoringCase does. Committed r103199: <http://trac.webkit.org/changeset/103199> (In reply to comment #2) > (From update of attachment 119790 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=119790&action=review > > > Source/WebCore/platform/KURL.cpp:1718 > > +bool charactersAreProtocol(const CharType* url, const char* protocol) > > This should have static on it for the same reason that isLetterMatchIgnoringCase does. Can I take that as an rs=you to add it? Yes. |