Bug 74814

Summary: Add a scrolling thread to the scrolling coordinator
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, efidler, gmak, levin+threading, manyoso, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+, kling: commit-queue-

Anders Carlsson
Reported 2011-12-18 10:42:00 PST
Add a scrolling thread to the scrolling coordinator
Attachments
Patch (14.30 KB, patch)
2011-12-18 10:45 PST, Anders Carlsson 		kling: review+
kling: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-12-18 10:45:09 PST
Created attachment 119768 [details] Patch
Andreas Kling
Comment 2 2011-12-18 10:53:39 PST
Comment on attachment 119768 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119768&action=review r=me with the preprocessor guard. > Source/WebCore/page/mac/ScrollingCoordinatorMac.mm:156 > + static ScrollingThread& scrollingThread = *new ScrollingThread(); Y U NO DEFINE_STATIC_LOCAL? > Source/WebKit2/WebProcess/WebPage/EventDispatcher.cpp:92 > + MutexLocker locker(m_scrollingCoordinatorsMutex); > + if (ScrollingCoordinator* scrollingCoordinator = m_scrollingCoordinators.get(pageID).get()) { > + PlatformWheelEvent platformWheelEvent = platform(wheelEvent); > + > + if (scrollingCoordinator->handleWheelEvent(platformWheelEvent)) { > + sendDidHandleEvent(pageID, wheelEvent); > + return; > + } > + } > + This block needs an ENABLE(THREADED_SCROLLING) guard.
Anders Carlsson
Comment 3 2011-12-18 10:56:30 PST
Committed r103180: <http://trac.webkit.org/changeset/103180>
Benjamin Poulain
Comment 4 2011-12-19 03:21:05 PST
Little build fix: http://trac.webkit.org/changeset/103227
Note You need to log in before you can comment on or make changes to this bug.