Bug 74808 – REGRESSION(r103149): prepare-ChangeLog outputs a warning

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Kentaro Hara]

After r103149, prepare-ChangeLog outputs the following warning due to missing the prototype declaration of main().

    main::main() called too early to check prototype at ./Tools/Scripts/prepare-ChangeLog line 117.

[Kentaro Hara]

Created attachment 119756 [details]
Patch

[David Kilzer (:ddkilzer)]

Comment on attachment 119756 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119756&action=review

r=me

> Tools/Scripts/prepare-ChangeLog:67
> +sub main();

Should be in alphabetical order.

[Kentaro Hara]

Created attachment 119759 [details]
patch for commit

[Kentaro Hara]

(In reply to comment #2)
> (From update of attachment 119756 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=119756&action=review
> 
> r=me
> 
> > Tools/Scripts/prepare-ChangeLog:67
> > +sub main();
> 
> Should be in alphabetical order.

Subroutines in this file had been declared in the order in which they defined. I sorted all subroutine declarations in the alphabetical order, and committed. Thanks.

[WebKit Review Bot]

Comment on attachment 119759 [details]
patch for commit

Clearing flags on attachment: 119759

Committed r103171: <http://trac.webkit.org/changeset/103171>