Bug 74805

Summary: Move timestamp down from PlatformEvent subclasses to the base class
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch andersca: review+

Sam Weinig
Reported 2011-12-17 23:43:34 PST
Move timestamp down from PlatformEvent subclasses to the base class
Attachments
Patch (32.08 KB, patch)
2011-12-17 23:45 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (32.05 KB, patch)
2011-12-17 23:49 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (34.83 KB, patch)
2011-12-18 11:36 PST, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2011-12-17 23:45:05 PST
Created attachment 119753 [details] Patch
WebKit Review Bot
Comment 2 2011-12-17 23:47:15 PST
Attachment 119753 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/win/PlatformMouseEventWin.cpp:89: Extra space before last semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] Source/WebCore/platform/wx/MouseEventWx.cpp:29: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2011-12-17 23:49:58 PST
Created attachment 119754 [details] Patch
WebKit Review Bot
Comment 4 2011-12-17 23:52:45 PST
Attachment 119754 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/wx/MouseEventWx.cpp:29: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 5 2011-12-18 11:36:03 PST
Created attachment 119770 [details] Patch
WebKit Review Bot
Comment 6 2011-12-18 11:38:11 PST
Attachment 119770 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/wx/MouseEventWx.cpp:29: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/wx/MouseEventWx.cpp:32: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 7 2011-12-18 11:45:48 PST
Committed r103181: <http://trac.webkit.org/changeset/103181>
Note You need to log in before you can comment on or make changes to this bug.