Bug 74793

Summary: CSSPrimitiveValue: Inline getIdent().
Product: WebKit Reporter: Andreas Kling <kling>
Component: CSSAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: macpherson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+

Andreas Kling
Reported 2011-12-17 15:08:12 PST
getIdent() is trivial, and the other getFoo() methods in CSSPrimitiveValue are already inline (excluding those that may set a DOM exception.)
Attachments
Patch (1.78 KB, patch)
2011-12-17 15:08 PST, Andreas Kling 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2011-12-17 15:08:50 PST
Created attachment 119738 [details] Patch
Antti Koivisto
Comment 2 2011-12-17 18:55:38 PST
Comment on attachment 119738 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119738&action=review > Source/WebCore/css/CSSPrimitiveValue.h:207 > + int getIdent() const { return m_primitiveUnitType != CSS_IDENT ? 0 : m_value.ident; } I would prefer equality check.
Andreas Kling
Comment 3 2011-12-17 19:26:13 PST
Committed r103161: <http://trac.webkit.org/changeset/103161>
Note You need to log in before you can comment on or make changes to this bug.