Bug 74793

Summary:

CSSPrimitiveValue: Inline getIdent().

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

CSS

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

macpherson, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	koivisto: review+

Description Andreas Kling 2011-12-17 15:08:12 PST

getIdent() is trivial, and the other getFoo() methods in CSSPrimitiveValue are already inline (excluding those that may set a DOM exception.)

Comment 1 Andreas Kling 2011-12-17 15:08:50 PST

Created attachment 119738 [details]
Patch

Comment 2 Antti Koivisto 2011-12-17 18:55:38 PST

Comment on attachment 119738 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119738&action=review

> Source/WebCore/css/CSSPrimitiveValue.h:207
> +    int getIdent() const { return m_primitiveUnitType != CSS_IDENT ? 0 : m_value.ident; }

I would prefer equality check.

Comment 3 Andreas Kling 2011-12-17 19:26:13 PST

Committed r103161: <http://trac.webkit.org/changeset/103161>