Bug 74791

Summary:

[Qt] Fix QtTestBrowser compilation with QtWidgets module

Product:

WebKit

Reporter:

Adenilson Cavalcanti Silva <savagobr>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Link with libQtWidgets	kenneth: review+, kenneth: commit-queue-
Only use QtWidgets module if using Qt5	none
Only use QtWidgets module if using Qt5, reuse previous test clause	none

Adenilson Cavalcanti Silva

Reported 2011-12-17 14:06:34 PST

Compilation will fail due to missing QT += widgets with current qt5 hash.

Attachments
Link with libQtWidgets (1.29 KB, patch) 2011-12-17 14:12 PST, Adenilson Cavalcanti Silva	kenneth: review+ kenneth: commit-queue-	Details Formatted Diff Diff
Only use QtWidgets module if using Qt5 (1.33 KB, patch) 2011-12-17 17:15 PST, Adenilson Cavalcanti Silva	no flags	Details Formatted Diff Diff
Only use QtWidgets module if using Qt5, reuse previous test clause (1.38 KB, patch) 2011-12-17 17:22 PST, Adenilson Cavalcanti Silva	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Adenilson Cavalcanti Silva

Comment 1 2011-12-17 14:12:15 PST

Created attachment 119735 [details] Link with libQtWidgets

Kenneth Rohde Christiansen

Comment 2 2011-12-17 15:22:49 PST

Comment on attachment 119735 [details] Link with libQtWidgets I think this should only be done with Qt5 right?

Adenilson Cavalcanti Silva

Comment 3 2011-12-17 17:15:02 PST

Created attachment 119742 [details] Only use QtWidgets module if using Qt5

Adenilson Cavalcanti Silva

Comment 4 2011-12-17 17:22:19 PST

Created attachment 119743 [details] Only use QtWidgets module if using Qt5, reuse previous test clause

Andreas Kling

Comment 5 2011-12-17 18:20:03 PST

Comment on attachment 119743 [details] Only use QtWidgets module if using Qt5, reuse previous test clause rs=me

WebKit Review Bot

Comment 6 2011-12-17 19:35:28 PST

Comment on attachment 119743 [details] Only use QtWidgets module if using Qt5, reuse previous test clause Clearing flags on attachment: 119743 Committed r103164: <http://trac.webkit.org/changeset/103164>

WebKit Review Bot

Comment 7 2011-12-17 19:35:32 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.