Bug 74785

Summary: [Qt] fast/canvas/2d.text.draw.fill.maxWidth.gradient.html fails with newer Qt5
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Critical CC: hausmann, laszlo.gombos, ossy, rafael.lobo, webkit.review.bot
Priority: P1 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2011-12-17 04:47:51 PST
fast/canvas/2d.text.draw.fill.maxWidth.gradient.html started to fail after updating Qt5: https://lists.webkit.org/pipermail/webkit-qt/2011-December/002279.html This test now fails with Qt5-WK1 and Qt5-WK2 too: --- /home/webkitbuildbot/slaves/release32bit-qt5/buildslave/qt-linux-32-release-qt5/build/layout-test-results/fast/canvas/2d.text.draw.fill.maxWidth.gradient-expected.txt +++ /home/webkitbuildbot/slaves/release32bit-qt5/buildslave/qt-linux-32-release-qt5/build/layout-test-results/fast/canvas/2d.text.draw.fill.maxWidth.gradient-actual.txt @@ -1,3 +1,3 @@ On success, there should only be a green rectangle. -TEST PASSED +TEST FAILED It might be a Qt bug, I don't know.
Attachments
Patch (1.49 KB, patch)
2012-01-05 05:03 PST, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2011-12-17 05:47:09 PST
Skipped by http://trac.webkit.org/changeset/103146
Csaba Osztrogonác
Comment 2 2011-12-23 02:03:14 PST
It is P1/critical, because it is a regression.
Simon Hausmann
Comment 3 2012-01-04 04:35:36 PST
Commit d52fd497f60a3c4456994f4f10e9451d611c9ea4 / http://codereview.qt-project.org/#change,11008 is the culprit.
Simon Hausmann
Comment 4 2012-01-04 07:32:10 PST
Upstream issue created https://bugreports.qt.nokia.com/browse/QTBUG-23450
Simon Hausmann
Comment 5 2012-01-05 05:03:14 PST
Created attachment 121263 [details] Patch
Simon Hausmann
Comment 6 2012-01-05 05:04:00 PST
Ossy, feel free to land this with the next qt5 update :)
Csaba Osztrogonác
Comment 7 2012-01-05 05:23:55 PST
Comment on attachment 121263 [details] Patch Thanks for the fix. r=me, I'll land it with Qt5 update.
Rafael Brandao
Comment 8 2012-01-17 06:03:06 PST
Is this issue solved? Can we close it then?
Csaba Osztrogonác
Comment 9 2012-01-17 06:05:07 PST
Comment on attachment 121263 [details] Patch Yes, but I'm missed to land the patch. cq+ to land it.
Csaba Osztrogonác
Comment 10 2012-01-17 06:34:17 PST
Committed r105150
Note You need to log in before you can comment on or make changes to this bug.