Bug 74763
| Summary: | Style bot should complain if someone tries to export an s_info class member by putting it in a .def file | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Hahnenberg <mhahnenberg> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | aroben, levin |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Mark Hahnenberg
Exporting ClassInfos across DLLs can cause badness if not done the right way (using JS_EXPORTDATA and *not* having it in the symbol export file). The style bot should know the correct way and should smack anybody's hand who tries to do it the incorrect way.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adam Roben (:aroben)
Basically we can just grep all .def files for "s_info" and complain if we find it.
Mark Hahnenberg
We don't have .def files any more. Hooray!