Bug 74713

Summary: [GTK] Use bit field for bool members of WebKitWindowPropertiesPrivate
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, pnormand, webkit.review.bot
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch gustavo: review+

Carlos Garcia Campos
Reported 2011-12-16 05:53:33 PST
Most of the members are bools, so we can reduce the memory footprint a bit.
Attachments
Patch (1.56 KB, patch)
2011-12-16 05:57 PST, Carlos Garcia Campos 		gustavo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2011-12-16 05:57:15 PST
Created attachment 119607 [details] Patch
WebKit Review Bot
Comment 2 2011-12-16 06:02:53 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Gustavo Noronha (kov)
Comment 3 2011-12-16 06:19:20 PST
Comment on attachment 119607 [details] Patch It's funny that you need to do this for the boolean type, but from what I read this seems to be indeed correct, so r=me
Carlos Garcia Campos
Comment 4 2011-12-16 06:46:40 PST
Committed r103068: <http://trac.webkit.org/changeset/103068>
Note You need to log in before you can comment on or make changes to this bug.