Bug 74711

Summary:

[GTK] Implement create/ready-to-show/close signals in MiniBrowser

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, gustavo, pnormand, webkit.review.bot

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Bug Depends on:

74709

Bug Blocks:

Attachments:

Description	Flags
Patch	pnormand: review+, webkit.review.bot: commit-queue-

Description Carlos Garcia Campos 2011-12-16 05:44:30 PST

It allows to open links in new windows, and it handles popups too.

Comment 1 Carlos Garcia Campos 2011-12-16 05:47:21 PST

Created attachment 119606 [details]
Patch

Comment 2 WebKit Review Bot 2011-12-16 06:22:26 PST

Comment on attachment 119606 [details]
Patch

Attachment 119606 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10910795

New failing tests:
http/tests/inspector/resource-parameters.html
http/tests/inspector-enabled/console-clear-arguments-on-frame-remove.html

Comment 3 Carlos Garcia Campos 2011-12-16 06:32:02 PST

(In reply to comment #2)
> (From update of attachment 119606 [details])
> Attachment 119606 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/10910795
> 
> New failing tests:
> http/tests/inspector/resource-parameters.html
> http/tests/inspector-enabled/console-clear-arguments-on-frame-remove.html

this looks unrelated to the patch.

Comment 4 Philippe Normand 2012-01-02 03:34:53 PST

Comment on attachment 119606 [details]
Patch

It looks ok to me, just one concern, what about the estimated-load-progress and title properties notifications in the new window? I think they should be handled like in the parent browser window.

Comment 5 Carlos Garcia Campos 2012-01-02 03:41:46 PST

(In reply to comment #4)
> (From update of attachment 119606 [details])
> It looks ok to me, just one concern, what about the estimated-load-progress and title properties notifications in the new window? I think they should be handled like in the parent browser window.

It's exactly the same, they are connected in constructed method of the BrowserWindow, or what do you mean?

Comment 6 Philippe Normand 2012-01-02 04:01:44 PST

Comment on attachment 119606 [details]
Patch

You're right indeed :)

Comment 7 Carlos Garcia Campos 2012-01-02 05:39:41 PST

Committed r103904: <http://trac.webkit.org/changeset/103904>