Summary: | invalidateNodeListsCacheAfterAttributeChanged has too many callers | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
Component: | DOM | Assignee: | Ryosuke Niwa <rniwa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | adamk, arko, arv, darin, sam, tkent, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 73853 | ||||||||
Attachments: |
|
Description
Ryosuke Niwa
2011-12-16 00:20:48 PST
Created attachment 119581 [details]
cleanup and fixes a bug
Created attachment 119582 [details]
Fixed if for MICRODATA
Ping reviewers. Comment on attachment 119582 [details] Fixed if for MICRODATA View in context: https://bugs.webkit.org/attachment.cgi?id=119582&action=review > Source/WebCore/dom/Node.cpp:1038 > + if (attrName != classAttr > +#if ENABLE(MICRODATA) > + && attrName != itemscopeAttr > + && attrName != itempropAttr > +#endif > + && attrName != nameAttr) > + return; If this needs to be in sync with something, can we extract this logic into a shared function? Comment on attachment 119582 [details] Fixed if for MICRODATA View in context: https://bugs.webkit.org/attachment.cgi?id=119582&action=review Thanks for the review! >> Source/WebCore/dom/Node.cpp:1038 >> + return; > > If this needs to be in sync with something, can we extract this logic into a shared function? It's hard to do at the moment because information is hidden in NodeListsNodeData but it'll be straight-forward once we turn NodeListsNodeData into a per-document cache (which I'm planning to do on the next patch). Committed r103116: <http://trac.webkit.org/changeset/103116> |