Bug 74688
| Summary: | REGRESSION(r103005): bidi-override-in-anonymous-block.html is failing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Hajime Morrita <morrita> |
| Component: | Layout and Rendering | Assignee: | Adam Barth <abarth> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | abarth, darin, eric, mitz, rniwa |
| Priority: | P1 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Hajime Morrita
It's not only for Chromium. Mac ports are also breaking.
I'm suspecting http://trac.webkit.org/changeset/102875, but not sure.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Hajime Morrita
According to the Chromium Builder,
http://build.webkit.org/builders/Chromium%20Linux%20Release%20%28Tests%29
It starts between r102992 and r102996. But there is no doubtful change.
Ryosuke Niwa
According to http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=fast%2Fcss%2Fbidi-override-in-anonymous-block.html
This is a regression from http://trac.webkit.org/changeset/103005/
Regression ranges:
Chromium Win Release (Tests): http://trac.webkit.org/log/?verbose=on&rev=103009&stop_rev=103004
Chromium Linux Release (Tests): http://trac.webkit.org/log/?verbose=on&rev=103006&stop_rev=103001
SnowLeopard Intel Release (Tests): http://trac.webkit.org/log/?verbose=on&rev=103005&stop_rev=103002
And r103002-r103004 can't affect rendering like the way the test is failing.
Darin Adler
I’m sure Adam will want to fix this, so assigning it to him to formalize that.
Ryosuke Niwa
Any update on this regression?
Adam Barth
Sorry, I didn't realize this was on my plate. I'll investigate on Tuesday.
Adam Barth
*** Bug 75236 has been marked as a duplicate of this bug. ***
Adam Barth
The new result is correct. This reflects the updated parsing of <rt> inside <rb> elements. I don't fully understand why the HTML5 spec changed in this regard, but from the discussion, it seems like this is the better parsing of ruby elements.
Ryosuke Niwa
(In reply to comment #7)
> The new result is correct. This reflects the updated parsing of <rt> inside <rb> elements. I don't fully understand why the HTML5 spec changed in this regard, but from the discussion, it seems like this is the better parsing of ruby elements.
Okay. Let's rebaseline then.
Adam Barth
Committed r103719: <http://trac.webkit.org/changeset/103719>
Ryosuke Niwa
Committed r103721: <http://trac.webkit.org/changeset/103721>