Bug 74685

Summary:

Give PlatformEvents a base class

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	andersca: review+

Sam Weinig

Reported 2011-12-15 21:35:06 PST

Give PlatformEvents a base class

Attachments
Patch (148.17 KB, patch) 2011-12-15 21:36 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (150.89 KB, patch) 2011-12-15 21:45 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (150.99 KB, patch) 2011-12-15 22:39 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (151.02 KB, patch) 2011-12-15 22:54 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (151.21 KB, patch) 2011-12-16 09:48 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (151.19 KB, patch) 2011-12-16 10:38 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (164.22 KB, patch) 2011-12-16 10:45 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (166.16 KB, patch) 2011-12-16 12:53 PST, Sam Weinig	andersca: review+	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2011-12-15 21:36:44 PST

Created attachment 119561 [details] Patch

Sam Weinig

Comment 2 2011-12-15 21:39:54 PST

Giving the EWS a chance to chew through this one. It touches a lot of platform files :(.

WebKit Review Bot

Comment 3 2011-12-15 21:41:02 PST

Attachment 119561 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/PlatformMouseEvent.h:97: Should have a space between // and comment [whitespace/comments] [4] Source/WebCore/platform/PlatformMouseEvent.h:137: The parameter name "button" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/PlatformMouseEvent.h:137: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/PlatformKeyboardEvent.h:69: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/platform/wx/MouseEventWx.cpp:40: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1187: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/dom/KeyboardEvent.cpp:40: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Total errors found: 7 in 85 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 4 2011-12-15 21:45:53 PST

Created attachment 119562 [details] Patch

WebKit Review Bot

Comment 5 2011-12-15 21:48:37 PST

Attachment 119562 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/platform/PlatformMouseEvent.h:97: Should have a space between // and comment [whitespace/comments] [4] Source/WebCore/platform/PlatformMouseEvent.h:137: The parameter name "button" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/PlatformMouseEvent.h:137: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1187: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/platform/PlatformKeyboardEvent.h:69: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/dom/KeyboardEvent.cpp:40: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/platform/wx/MouseEventWx.cpp:40: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 7 in 90 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 6 2011-12-15 22:06:45 PST

Comment on attachment 119562 [details] Patch Attachment 119562 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10895582

Sam Weinig

Comment 7 2011-12-15 22:39:59 PST

Created attachment 119569 [details] Patch

WebKit Review Bot

Comment 8 2011-12-15 22:42:38 PST

Attachment 119569 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/platform/PlatformMouseEvent.h:97: Should have a space between // and comment [whitespace/comments] [4] Source/WebCore/platform/PlatformMouseEvent.h:137: The parameter name "button" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/PlatformMouseEvent.h:137: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1187: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/platform/PlatformKeyboardEvent.h:69: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/dom/KeyboardEvent.cpp:40: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/platform/wx/MouseEventWx.cpp:40: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 7 in 90 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 9 2011-12-15 22:54:51 PST

Created attachment 119571 [details] Patch

WebKit Review Bot

Comment 10 2011-12-15 22:58:09 PST

Attachment 119571 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/platform/PlatformMouseEvent.h:97: Should have a space between // and comment [whitespace/comments] [4] Source/WebCore/platform/PlatformMouseEvent.h:137: The parameter name "button" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/PlatformMouseEvent.h:137: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1187: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/platform/PlatformKeyboardEvent.h:69: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/dom/KeyboardEvent.cpp:40: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/platform/wx/MouseEventWx.cpp:40: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 7 in 90 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 11 2011-12-15 23:21:48 PST

Comment on attachment 119571 [details] Patch Attachment 119571 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10914573

Early Warning System Bot

Comment 12 2011-12-16 00:03:25 PST

Comment on attachment 119571 [details] Patch Attachment 119571 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10900593

Sam Weinig

Comment 13 2011-12-16 09:48:10 PST

Created attachment 119626 [details] Patch

WebKit Review Bot

Comment 14 2011-12-16 09:49:43 PST

Attachment 119626 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/platform/PlatformMouseEvent.h:97: Should have a space between // and comment [whitespace/comments] [4] Source/WebCore/platform/PlatformMouseEvent.h:137: The parameter name "button" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/PlatformMouseEvent.h:137: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1187: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/platform/PlatformKeyboardEvent.h:69: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/dom/KeyboardEvent.cpp:40: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/platform/wx/MouseEventWx.cpp:40: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 7 in 90 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 15 2011-12-16 09:59:05 PST

Comment on attachment 119626 [details] Patch Attachment 119626 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10904775

WebKit Review Bot

Comment 16 2011-12-16 10:28:56 PST

Comment on attachment 119626 [details] Patch Attachment 119626 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10904784

Sam Weinig

Comment 17 2011-12-16 10:38:58 PST

Created attachment 119632 [details] Patch

WebKit Review Bot

Comment 18 2011-12-16 10:43:04 PST

Attachment 119632 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/platform/PlatformMouseEvent.h:97: Should have a space between // and comment [whitespace/comments] [4] Source/WebCore/platform/PlatformMouseEvent.h:137: The parameter name "button" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/PlatformMouseEvent.h:137: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1187: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/platform/PlatformKeyboardEvent.h:69: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/dom/KeyboardEvent.cpp:40: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/platform/wx/MouseEventWx.cpp:40: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 7 in 90 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 19 2011-12-16 10:45:34 PST

Created attachment 119633 [details] Patch

WebKit Review Bot

Comment 20 2011-12-16 10:48:59 PST

Attachment 119633 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/platform/PlatformMouseEvent.h:97: Should have a space between // and comment [whitespace/comments] [4] Source/WebCore/platform/PlatformMouseEvent.h:137: The parameter name "button" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/PlatformMouseEvent.h:137: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1187: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/platform/PlatformKeyboardEvent.h:69: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/dom/KeyboardEvent.cpp:40: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/platform/wx/MouseEventWx.cpp:40: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 7 in 91 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 21 2011-12-16 12:53:54 PST

Created attachment 119656 [details] Patch

WebKit Review Bot

Comment 22 2011-12-16 13:07:23 PST

Attachment 119656 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1187: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebCore/platform/PlatformKeyboardEvent.h:69: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebCore/dom/KeyboardEvent.cpp:40: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Total errors found: 3 in 91 files If any of these errors are false positives, please file a bug against check-webkit-style.

Anders Carlsson

Comment 23 2011-12-16 13:16:19 PST

Comment on attachment 119656 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119656&action=review > Source/WebCore/platform/PlatformEvent.h:112 > + You should add a protected destructor here as well, that way people won't inadvertly delete a platform event. The destructor doesn't need to be virtual.

Sam Weinig

Comment 24 2011-12-16 14:46:38 PST

Committed r103112: <http://trac.webkit.org/changeset/103112>

Note You need to log in before you can comment on or make changes to this bug.