Bug 74656
| Summary: | [Chromium] new-run-webkit-tests attempts to compare images for fast/filesystem/workers/file-writer-gc-blob.html | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Dmitry Lomov <dslomov> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dpranke, dslomov, ericu, hayato, rniwa |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Dmitry Lomov
fast/filesystem/workers/file-writer-gc-blob.html and fast/filesystem/workers/file-writer-write-overlapped.html are affected
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Dirk Pranke
I have reproduced this and am looking at it now.
Dirk Pranke
Okay, it looks like when those tests were added to the repository, Eric added the expected results as fast/filesystem/workers/file-writer-gc-blob-expected.html instead of fast/filesystem/workers/file-writer-gc-blob-expected.txt.
As a result, new-run-webkit-tests thinks this is a reftest and runs both of them and attempts to compare the output. But, there is no output when we run things as dumpAsText(), so we compare "no png" to "the text rendered as a png".
Looks like this will happen for fast/filesystem/workers/file-writer-write-overlapped-expected.html as well.
I think you just want to rename the -expected.html files.
Dirk Pranke
rniwa, hayato - interesting failure to note here ... we're treating things as reftests that aren't reftests.
Eric U.
Ug--sorry about that. Will fix.
Dirk Pranke
we should probably file a separate bug to make this failure case distinct from a regular image failure somehow.
Hayato Ito
I agree. Let me think how we should detect and report these type of errors.
(In reply to comment #5)
> we should probably file a separate bug to make this failure case distinct from a regular image failure somehow.
Eric U.
Dmitry fixed this months ago.