Bug 74650

Summary: NRWT should use free + inactive memory for default_child_processes on OS X (and never return < 1 process)
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, dpranke, eric, ojan, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: OS X 10.7   
Bug Depends on:    
Bug Blocks: 77419    
Attachments:
Description Flags
Patch none

Alexey Proskuryakov
Reported 2011-12-15 14:56:59 PST
run-webkit-tests doesn't start on my machine. This appears the be because the script checks for free memory. An OS X system is expected to have as close to 0 free memory as possible, because there is no reason to evict stuff from caches before someone asks for memory. Can a better heuristic be found, perhaps based on inactive memory? Can at least one process be always started? PhysMem: 1146M wired, 3105M active, 3867M inactive, 8119M used, 61M free. VM: 253G vsize, 1122M framework vsize, 81575868(0) pageins, 929707(0) pageouts.
Attachments
Patch (4.92 KB, patch)
2011-12-15 15:22 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-12-15 15:02:55 PST
Yeah, I'm not a huge fan of this check. I'm happy to change it (or assist you in changing it) to use a different heuristic. See bug 74021 and bug 73847.
Eric Seidel (no email)
Comment 2 2011-12-15 15:11:21 PST
does "pages inactive" in vm_stat include free pages? Or are you asking for this heuristic to add both?
Eric Seidel (no email)
Comment 3 2011-12-15 15:22:37 PST
Created attachment 119506 [details] Patch
WebKit Review Bot
Comment 4 2011-12-15 22:03:12 PST
Comment on attachment 119506 [details] Patch Clearing flags on attachment: 119506 Committed r103026: <http://trac.webkit.org/changeset/103026>
WebKit Review Bot
Comment 5 2011-12-15 22:03:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.