Bug 74612
| Summary: | Each worker separately logs its complaint about the directory I am in | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dpranke, eric |
| Priority: | P2 | Keywords: | NRWT |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Darin Adler
When I run tests, I get this:
The current directory (/Users/darin/Safari) is not a WebKit checkout, using /Users/darin/Safari/OpenSource
Starting 8 workers ...The current directory (/Users/darin/Safari) is not a WebKit checkout, using /Users/darin/Safari/OpenSource
The current directory (/Users/darin/Safari) is not a WebKit checkout, using /Users/darin/Safari/OpenSource
The current directory (/Users/darin/Safari) is not a WebKit checkout, using /Users/darin/Safari/OpenSource
The current directory (/Users/darin/Safari) is not a WebKit checkout, using /Users/darin/Safari/OpenSource
The current directory (/Users/darin/Safari) is not a WebKit checkout, using /Users/darin/Safari/OpenSource
The current directory (/Users/darin/Safari) is not a WebKit checkout, using /Users/darin/Safari/OpenSource
The current directory (/Users/darin/Safari) is not a WebKit checkout, using /Users/darin/Safari/OpenSource
The current directory (/Users/darin/Safari) is not a WebKit checkout, using /Users/darin/Safari/OpenSource
I don’t need to see that log message 9 times. In fact, I’d prefer not to see it even once.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
Sure thing. Easy to fix. Just an unintented consequence of re-using single-process code in our new multi-process architecture. :)
Eric Seidel (no email)
You'll likely want this when running webkit-patch apply-from-bug outside of a webkit directory, but not when running new-run-webkit-tests. Or at least not 7 times. :)
Then again, it's possible it's not even useful when running webkit-patch from outside of a webkit directory.
Dirk Pranke
I agree w/ Darin; new-run-webkit-tests shouldn't be complaining about this at all by default, and it should definitely only be complaining once. Can we change scm/detection.py to provide a am_inside_the_checkout() function so that webkit-patch can call this separately and log the warning?
Eric Seidel (no email)
(In reply to comment #3)
> I agree w/ Darin; new-run-webkit-tests shouldn't be complaining about this at all by default, and it should definitely only be complaining once. Can we change scm/detection.py to provide a am_inside_the_checkout() function so that webkit-patch can call this separately and log the warning?
Sounds like a good approach.
I agree. webkit-patch should be specifically opting into this warning, instead of all SCM clients causing it.
Dirk Pranke
I think this was fixed in r120646. Please let me know if you're still seeing an issue.