Bug 74552 – binding a member function should ref/deref the object pointer if needed

• Component: New Bugs
• Status: RESOLVED FIXED

[Anders Carlsson]

binding a member function should ref/deref the object pointer if needed

[Anders Carlsson]

Created attachment 119314 [details]
Patch

[WebKit Review Bot]

Attachment 119314 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Tools/TestWebKitAPI/Tests/WTF/Functional.cpp:144:  Extra space before ( in function call  [whitespace/parens] [4]
Tools/TestWebKitAPI/Tests/WTF/Functional.cpp:147:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 119314 [details]
Patch

Attachment 119314 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10900013

[Sam Weinig]

Comment on attachment 119314 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119314&action=review

> Source/JavaScriptCore/wtf/Functional.h:160
> +template<typename T, bool> struct RefAndDeref {

You should note what the bool means here.

[Anders Carlsson]

Committed r102857: <http://trac.webkit.org/changeset/102857>