Bug 74549

Summary: Web Inspector: Switch to type-safe JSON ConsoleMessage.cpp, InspectorDOMAgent.cpp, InspectorDebuggerAgent.cpp, ScriptCallFrame.cpp
Product: WebKit Reporter: Peter Rybin <peter.rybin>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, peter.rybin, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 72861    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Peter Rybin
Reported 2011-12-14 15:41:56 PST
Switch some core agents to newly created type-safe JSON TypeBuilder API.
Attachments
Patch (11.15 KB, patch)
2011-12-14 15:50 PST, Peter Rybin 		no flags
DetailsFormatted DiffDiff
Patch (13.28 KB, patch)
2011-12-15 11:42 PST, Peter Rybin 		no flags
DetailsFormatted DiffDiff
Patch (14.81 KB, patch)
2011-12-15 14:11 PST, Peter Rybin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Peter Rybin
Comment 1 2011-12-14 15:50:17 PST
Created attachment 119311 [details] Patch
WebKit Review Bot
Comment 2 2011-12-14 16:50:12 PST
Comment on attachment 119311 [details] Patch Attachment 119311 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10910015 New failing tests: inspector/protocol/console-agent.html
Pavel Feldman
Comment 3 2011-12-15 00:18:06 PST
Comment on attachment 119311 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119311&action=review Great job! > Source/WebCore/inspector/ScriptCallFrame.cpp:67 > + String::number(m_lineNumber)) Please do a drive-by fix to the protocol itself instead of this workaround. You can also fix the Inspector-0.1.json in this case - it is clearly a typo.
Peter Rybin
Comment 4 2011-12-15 11:42:12 PST
Created attachment 119473 [details] Patch
WebKit Review Bot
Comment 5 2011-12-15 12:43:27 PST
Comment on attachment 119473 [details] Patch Attachment 119473 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10915004 New failing tests: inspector/protocol/console-agent.html
Peter Rybin
Comment 6 2011-12-15 14:11:28 PST
Created attachment 119501 [details] Patch
Ilya Tikhonovsky
Comment 7 2011-12-18 07:06:30 PST
Comment on attachment 119501 [details] Patch Clearing flags on attachment: 119501 Committed r103174: <http://trac.webkit.org/changeset/103174>
Ilya Tikhonovsky
Comment 8 2011-12-18 07:06:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.