Bug 74542

Summary: Implement flexDirection and flexWrap and make flexFlow a proper shorthand.
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt, macpherson, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch tony: review+

Ojan Vafai
Reported 2011-12-14 14:46:38 PST
Implement flexDirection and flexWrap and make flexFlow a proper shorthand.
Attachments
Patch (36.00 KB, patch)
2011-12-14 14:48 PST, Ojan Vafai 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2011-12-14 14:48:19 PST
Created attachment 119302 [details] Patch
Tony Chang
Comment 2 2011-12-14 15:20:20 PST
Comment on attachment 119302 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119302&action=review Maybe add a test case that sets (direction|wrap) and flow and the last one set wins. > LayoutTests/css3/flexbox/script-tests/css-properties.js:154 > + shouldBeEqualToString('flexbox.style.webkitFlexFlow', (expected).replace(/^ /, '').replace(/ $/, '')); Nit: Remove () around expected.
Ojan Vafai
Comment 3 2011-12-14 15:39:36 PST
Committed r102837: <http://trac.webkit.org/changeset/102837>
Note You need to log in before you can comment on or make changes to this bug.