Bug 74534

Summary: Web Inspector: CodeGeneratorInspector.py convert script conditions to precompiler #ifs
Product: WebKit Reporter: Peter Rybin <peter.rybin>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, peter.rybin, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 72861    
Attachments:
Description Flags
Patch none

Peter Rybin
Reported 2011-12-14 13:15:21 PST
Currently generator generates different outputs depending on command-line parameters. Re-implement it so that output is always the same, but has precompiler #ifs. This is cleaner.
Attachments
Patch (10.96 KB, patch)
2011-12-14 17:49 PST, Peter Rybin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Peter Rybin
Comment 1 2011-12-14 17:49:15 PST
Created attachment 119352 [details] Patch
Ilya Tikhonovsky
Comment 2 2011-12-14 21:38:15 PST
please attach samples of the generated files.
Ilya Tikhonovsky
Comment 3 2011-12-15 06:20:02 PST
Comment on attachment 119352 [details] Patch Clearing flags on attachment: 119352 Committed r102933: <http://trac.webkit.org/changeset/102933>
Ilya Tikhonovsky
Comment 4 2011-12-15 06:20:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.