Bug 74531

Summary:

Filter amounts should accept percentages

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

CSS

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarrin, eoconnor, macpherson, simon.fraser, webkit-bug-importer, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	cmarrin: review+

Description Dean Jackson 2011-12-14 12:50:15 PST

Filter shorthands like grayscale() should accept % values. See the spec for reference.

Comment 1 Radar WebKit Bug Importer 2011-12-14 12:50:58 PST

<rdar://problem/10581759>

Comment 2 Simon Fraser (smfr) 2011-12-14 17:25:03 PST

Created attachment 119346 [details]
Patch

Comment 3 Simon Fraser (smfr) 2011-12-14 17:30:54 PST

http://trac.webkit.org/changeset/102855

Comment 4 Luke Macpherson 2011-12-14 18:08:48 PST

Comment on attachment 119346 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119346&action=review

> Source/WebCore/css/CSSStyleSelector.cpp:5356
> +                if (firstValue->primitiveType() == CSSPrimitiveValue::CSS_PERCENTAGE)

You can just use firstValue->isPercentage() here.

Comment 5 Dean Jackson 2011-12-16 13:41:28 PST

(In reply to comment #4)
> (From update of attachment 119346 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=119346&action=review
> 
> > Source/WebCore/css/CSSStyleSelector.cpp:5356
> > +                if (firstValue->primitiveType() == CSSPrimitiveValue::CSS_PERCENTAGE)
> 
> You can just use firstValue->isPercentage() here.

I'll change this in https://bugs.webkit.org/show_bug.cgi?id=74736