Bug 74526

Summary:

[Qt][WK2] Setting Download as action for navigation request crashes WebProcess

Product:

WebKit

Reporter:

Rafael Brandao <rafael.lobo>

Component:

WebKit Qt

Assignee:

Jesus Sanchez-Palencia <jesus>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

rafael.lobo

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Bug Depends on:

Bug Blocks:

74541

Attachments:

Description	Flags
This adds simple handler to navigation request on MiniBrowser, so you can see it crashing.	none
Patch	none

Rafael Brandao

Reported 2011-12-14 11:26:28 PST

An easy way to check this out is to handle onNavigationRequested on MiniBrowser for example. I`ve added a small diff that adds this feature on MiniBrowser. In order to crash it, just click with middle button on any link. You'll see the following output: We are supposed to start a download. WARNING: The web process experienced a crash on 'http://www.google.com.br/'.

Attachments
This adds simple handler to navigation request on MiniBrowser, so you can see it crashing. (1.19 KB, patch) 2011-12-14 11:27 PST, Rafael Brandao	no flags	Details Formatted Diff Diff
Patch (1.67 KB, patch) 2011-12-14 14:44 PST, Jesus Sanchez-Palencia	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Rafael Brandao

Comment 1 2011-12-14 11:27:19 PST

Created attachment 119262 [details] This adds simple handler to navigation request on MiniBrowser, so you can see it crashing.

Jesus Sanchez-Palencia

Comment 2 2011-12-14 13:53:07 PST

Backtrace shows that this is not related to the Download code path itself but to ResouceRequest and ThirdPartyCookies. IIRC, this has been recently refactored by Simon. I will talk to him. #0 0x00007f59a4c1bd1a in WebCore::thirdPartyCookiePolicyPermits Source/WebCore/platform/qt/ThirdPartyCookiesQt.cpp:65 #1 0x00007f59a4c0829d in WebCore::ResourceRequest::toNetworkRequest Source/WebCore/platform/network/qt/ResourceRequestQt.cpp:83 #2 0x00007f59a407ce55 in WebKit::Download::start Source/WebKit2/WebProcess/Downloads/qt/DownloadQt.cpp:48

Jesus Sanchez-Palencia

Comment 3 2011-12-14 14:44:57 PST

Created attachment 119301 [details] Patch

Jesus Sanchez-Palencia

Comment 4 2011-12-15 05:18:56 PST

Comment on attachment 119301 [details] Patch Clearing flags on attachment: 119301 Committed r102926: <http://trac.webkit.org/changeset/102926>

Jesus Sanchez-Palencia

Comment 5 2011-12-15 05:19:05 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.