Summary: | <wbr> in <pre> causes some new lines to be ignored | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
Component: | DOM | Assignee: | Darin Adler <darin> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ian, mitz | ||||||
Priority: | P2 | Keywords: | GoogleBug, HasReduction, InRadar | ||||||
Version: | 420+ | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.4 | ||||||||
Attachments: |
|
Description
Sam Weinig
2006-02-24 18:06:06 PST
Created attachment 6709 [details]
test case
Test case showing bad behavior. In Firefox, the line break is made.
Created attachment 14449 [details]
patch that implements proper parsing and rendering for <wbr>
Comment on attachment 14449 [details]
patch that implements proper parsing and rendering for <wbr>
+++ WebCore/dom/Node.cpp (working copy)
Please include the changes to Node.cpp in the change log. Did you actually hit a case where createRenderer() returned 0 despite rendererIsNeeded() returning true? If not, can you replace or augment the if(r) with an ASSERT(r)?
What's the following all about?
Property changes on: LayoutTests/fast/text/wbr.html
___________________________________________________________________
Name: svn:executable
+ *
r=me
> Please include the changes to Node.cpp in the change log. Did you actually hit > a case where createRenderer() returned 0 despite rendererIsNeeded() returning > true? If not, can you replace or augment the if(r) with an ASSERT(r)? I crashed while running layout tests. I didn't investigate this in great detail, and I forgot about it completely! I thought it was an obvious mistake that there was a null check on one line and no null check on the next line. > What's the following all about? [executable flag on some files] Not sure -- obviously my mistake. Committed revision 21405. |