Bug 74518

Summary: Create reftest for render-region-renderer
Product: WebKit Reporter: Larry McLister <lmcliste>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: lmcliste, WebkitBugTracker, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
tony: review+, tony: commit-queue-
Patch
none
Updated patch none

Larry McLister
Reported 2011-12-14 10:36:32 PST
This regions test should be converted to a reftest from a bitmap test. LayoutTests/fast/regions/render-region-renderer
Attachments
Patch (9.18 KB, patch)
2011-12-14 11:36 PST, Larry McLister 		no flags
DetailsFormatted DiffDiff
Patch (10.17 KB, patch)
2011-12-14 11:43 PST, Larry McLister 		tony: review+
tony: commit-queue-
DetailsFormatted DiffDiff
Patch (10.79 KB, patch)
2011-12-14 16:03 PST, Larry McLister 		no flags
DetailsFormatted DiffDiff
Updated patch (10.16 KB, patch)
2011-12-15 11:42 PST, Larry McLister 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Larry McLister
Comment 1 2011-12-14 11:36:28 PST
Created attachment 119266 [details] Patch
Larry McLister
Comment 2 2011-12-14 11:43:44 PST
Created attachment 119269 [details] Patch
Tony Chang
Comment 3 2011-12-14 15:52:51 PST
Comment on attachment 119269 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119269&action=review > LayoutTests/fast/regions/render-region-renderer-expected.html:57 > + <div class="border size"></div> > + <div class="border size pos"></div> > + > + <div class="border size2 pos1"></div> Nit: Indention is weird. > LayoutTests/fast/regions/render-region-renderer-expected.html:58 > + <div class="region border size2 pos2 outline"></div> Nit: Remove |region|?
Larry McLister
Comment 4 2011-12-14 16:03:55 PST
Created attachment 119313 [details] Patch
Larry McLister
Comment 5 2011-12-15 11:42:32 PST
Created attachment 119474 [details] Updated patch
WebKit Review Bot
Comment 6 2011-12-15 16:37:24 PST
Comment on attachment 119474 [details] Updated patch Clearing flags on attachment: 119474 Committed r102997: <http://trac.webkit.org/changeset/102997>
WebKit Review Bot
Comment 7 2011-12-15 16:37:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.