Bug 74518

Summary: Create reftest for render-region-renderer
Product: WebKit Reporter: Larry McLister <lmcliste>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: lmcliste, WebkitBugTracker, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
tony: review+, tony: commit-queue-
Patch
none
Updated patch none

Description Larry McLister 2011-12-14 10:36:32 PST 
This regions test should be converted to a reftest from a bitmap test.

LayoutTests/fast/regions/render-region-renderer
Comment 1 Larry McLister 2011-12-14 11:36:28 PST 
Created attachment 119266 [details]
Patch
Comment 2 Larry McLister 2011-12-14 11:43:44 PST 
Created attachment 119269 [details]
Patch
Comment 3 Tony Chang 2011-12-14 15:52:51 PST 
Comment on attachment 119269 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119269&action=review

> LayoutTests/fast/regions/render-region-renderer-expected.html:57
> +	    <div class="border size"></div>
> +	    <div class="border size pos"></div>
> +	
> +	    <div class="border size2 pos1"></div>

Nit: Indention is weird.

> LayoutTests/fast/regions/render-region-renderer-expected.html:58
> +    	<div class="region border size2 pos2 outline"></div>

Nit: Remove |region|?
Comment 4 Larry McLister 2011-12-14 16:03:55 PST 
Created attachment 119313 [details]
Patch
Comment 5 Larry McLister 2011-12-15 11:42:32 PST 
Created attachment 119474 [details]
Updated patch
Comment 6 WebKit Review Bot 2011-12-15 16:37:24 PST 
Comment on attachment 119474 [details]
Updated patch

Clearing flags on attachment: 119474

Committed r102997: <http://trac.webkit.org/changeset/102997>
Comment 7 WebKit Review Bot 2011-12-15 16:37:29 PST 
All reviewed patches have been landed.  Closing bug.