Bug 74507

Summary: Minor refactor to Parser::parseTryStatement
Product: WebKit Reporter: Andy Wingo <wingo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, oliver, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andy Wingo
Reported 2011-12-14 08:37:06 PST
Currently, the parser binds an identifier for the exception of a `catch' block by going directly to the scope object. The patch to be attached makes it use the Parser object's method. This will facilitate future checks for conflicting block-scoped bindings.
Attachments
Patch (1.68 KB, patch)
2011-12-14 08:38 PST, Andy Wingo 		no flags
DetailsFormatted DiffDiff
Patch (20.37 KB, patch)
2011-12-14 09:03 PST, Andy Wingo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andy Wingo
Comment 1 2011-12-14 08:38:22 PST
Created attachment 119223 [details] Patch
Andy Wingo
Comment 2 2011-12-14 09:03:45 PST
Created attachment 119229 [details] Patch
Andy Wingo
Comment 3 2011-12-14 09:04:54 PST
Comment on attachment 119229 [details] Patch Sorry, uploaded this patch to the wrong bug. The previous one is the right one.
Geoffrey Garen
Comment 4 2011-12-14 10:37:51 PST
Comment on attachment 119223 [details] Patch r=me
WebKit Review Bot
Comment 5 2011-12-15 05:46:12 PST
Comment on attachment 119223 [details] Patch Clearing flags on attachment: 119223 Committed r102931: <http://trac.webkit.org/changeset/102931>
WebKit Review Bot
Comment 6 2011-12-15 05:46:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.