Bug 74497

Summary: [Refactoring] In prepare-ChangeLog, make several global variables be used only through parameter passing
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: Tools / TestsAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, ddkilzer, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73531    
Attachments:
Description Flags
Patch
none
rebased patch none

Kentaro Hara
Reported 2011-12-14 04:17:03 PST
We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest manner. This bug is one of the incremental refactorings to remove all top-level code and global variables from prepare-ChangeLog. Global variables in prepare-ChangeLog can be categorized as follows: [A: Constant variables] $changeLogTimeZone $SVN $GIT %supportedTestExtensions [B: Arguments] $bugDescription $bugNumber $name $emailAddress $mergeBase $gitCommit $gitIndex $gitReviewer $openChangeLogs $writeChangeLogs $showHelp $spewDiff $updateChangeLogs $parseOptionsResult [C: Global variables that are used many times here and there] $isSVN $isGit [D: Global variables that are used only a few times] %paths $changedFiles $conflictFiles $functionLists $addedRegressionTests $bugURL $filesInChangeLog $prefixes $changeLogs In this bug, we remove several global variables in [B]. Accurately, we make $bugDescription, $bugNumber, $name, $emailAddress, $gitReviewer and $writeChangeLogs be used only through parameter passing. I'll remove all global variables completely in the next bug.
Attachments
Patch (4.93 KB, patch)
2011-12-14 04:22 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
rebased patch (4.82 KB, patch)
2011-12-15 04:29 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2011-12-14 04:22:57 PST
Created attachment 119200 [details] Patch
Kentaro Hara
Comment 2 2011-12-15 04:29:28 PST
Created attachment 119412 [details] rebased patch
WebKit Review Bot
Comment 3 2011-12-15 15:13:57 PST
Comment on attachment 119412 [details] rebased patch Clearing flags on attachment: 119412 Committed r102988: <http://trac.webkit.org/changeset/102988>
WebKit Review Bot
Comment 4 2011-12-15 15:14:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.