Bug 74428

Summary: Create reftest for outline-sides-in-region
Product: WebKit Reporter: Ethan Malasky <emalasky>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: lmcliste, WebkitBugTracker, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
add reftest, adjust test case, remove old expected files
none
reftest, removals, plus test enablement for chromium
darin: review+
one more, incorporating cleanup suggestions none

Ethan Malasky
Reported 2011-12-13 11:36:03 PST
This test should be satisfied with a reftest instead of a bitmap test.
Attachments
add reftest, adjust test case, remove old expected files (7.43 KB, patch)
2011-12-13 13:01 PST, Ethan Malasky 		no flags
DetailsFormatted DiffDiff
reftest, removals, plus test enablement for chromium (8.42 KB, patch)
2011-12-13 13:59 PST, Ethan Malasky 		darin: review+
DetailsFormatted DiffDiff
one more, incorporating cleanup suggestions (8.19 KB, patch)
2011-12-14 14:18 PST, Ethan Malasky 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ethan Malasky
Comment 1 2011-12-13 13:01:53 PST
Created attachment 119073 [details] add reftest, adjust test case, remove old expected files
Ethan Malasky
Comment 2 2011-12-13 13:59:45 PST
Created attachment 119080 [details] reftest, removals, plus test enablement for chromium
Darin Adler
Comment 3 2011-12-14 11:00:43 PST
Comment on attachment 119080 [details] reftest, removals, plus test enablement for chromium View in context: https://bugs.webkit.org/attachment.cgi?id=119080&action=review > LayoutTests/fast/regions/outline-sides-in-region-expected.html:15 > + <div id="region"> > + <div id="source"> I suggest omitting the ids. > LayoutTests/fast/regions/outline-sides-in-region.html:10 > + /* There appears to be a bug in margin-top collapsing for the first region. > + That issue will be filed separately. For now, forcing margin-top:0 allows us > + to create an accurate reftest for outline drawing. */ Strange indentation here. Also, we normally use // comments rather than /* comments.
Ethan Malasky
Comment 4 2011-12-14 14:00:46 PST
Thanks, Darin. Applying your suggestions. Will post a cleaner patch.
Ethan Malasky
Comment 5 2011-12-14 14:18:00 PST
Created attachment 119295 [details] one more, incorporating cleanup suggestions Removed ids, and also the whole CSS block comment, since astearns has since verified that the margin-top non-collapsing in the region is intended behavior.
WebKit Review Bot
Comment 6 2011-12-14 14:57:35 PST
Comment on attachment 119295 [details] one more, incorporating cleanup suggestions Clearing flags on attachment: 119295 Committed r102830: <http://trac.webkit.org/changeset/102830>
WebKit Review Bot
Comment 7 2011-12-14 14:57:40 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.