Bug 7440

Summary: Floats not positioned correctly
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://etuovi.com
Attachments:
Description Flags
testcase
none
patch hyatt: review+

Antti Koivisto
Reported 2006-02-23 21:25:15 PST
In etuovi.com the password entry field is not visible and there is overlapping text under "Oma etuovi" headline. The problem is with float positioning.
Attachments
testcase (388 bytes, text/html)
2006-02-23 21:28 PST, Antti Koivisto
no flags
patch (938 bytes, patch)
2006-02-23 22:33 PST, Antti Koivisto
hyatt: review+
Antti Koivisto
Comment 1 2006-02-23 21:28:14 PST
Created attachment 6693 [details] testcase
Antti Koivisto
Comment 2 2006-02-23 22:33:06 PST
Created attachment 6696 [details] patch Correct the use of QPtrList in RenderBlock::positionNewFloats(). In case all list entries needed positioning, the list current() pointer would get cleared and only the first entry would actually be positioned.
Dave Hyatt
Comment 3 2006-02-24 00:13:15 PST
Comment on attachment 6696 [details] patch r=me
Darin Adler
Comment 4 2006-02-24 08:23:30 PST
To land, we need to turn the test case into a layout test and write ChangeLog.
Antti Koivisto
Comment 5 2006-02-24 09:48:12 PST
(In reply to comment #4) > To land, we need to turn the test case into a layout test and write ChangeLog. > I can do that to test my new commit powers. Anything I need to know about the process?
Note You need to log in before you can comment on or make changes to this bug.