Bug 74375
| Summary: | [chromium] static initializer in ScrollbarThemeChromiumMac.mm | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tony Chang <tony> |
| Component: | Platform | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | sail, thakis |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | Unspecified | ||
| Bug Depends on: | 61144 | ||
| Bug Blocks: | 74365 | ||
Tony Chang
/Users/tc/WebKit/Source/WebCore/WebCore.gyp/../platform/chromium/ScrollbarThemeChromiumMac.mm:155:34: error: declaration requires a global constructor [-Werror,-Wglobal-constructors]
static ScrollbarButtonsPlacement gButtonPlacement = isScrollbarOverlayAPIAvailable() ? ScrollbarButtonsNone : ScrollbarButtonsDoubleEnd;
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This global is set in updateArrowPlacement, so it wasn't obvious to me what the right way to fix this is. Can we just move it into a static function?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Nico Weber
Sail has a CL to remove this in bug 61144
Tony Chang
Fixed in bug 61144 by http://trac.webkit.org/changeset/103354 .