Bug 74364

Summary: [Qt][WK2] Move undo & edit command PageClient callbacks into QtWebUndoController
Product: WebKit Reporter: Caio Marcelo de Oliveira Filho <cmarcelo>
Component: New BugsAssignee: Caio Marcelo de Oliveira Filho <cmarcelo>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, jesus, menard, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 72943    
Attachments:
Description Flags
Patch hausmann: review+

Caio Marcelo de Oliveira Filho
Reported 2011-12-12 15:51:29 PST
[Qt][WK2] Move undo & edit command PageClient callbacks into QtWebUndoController
Attachments
Patch (19.56 KB, patch)
2011-12-12 15:53 PST, Caio Marcelo de Oliveira Filho 		hausmann: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Caio Marcelo de Oliveira Filho
Comment 1 2011-12-12 15:53:36 PST
Created attachment 118891 [details] Patch
Jesus Sanchez-Palencia
Comment 2 2011-12-12 18:38:03 PST
(In reply to comment #1) > Created an attachment (id=118891) [details] > Patch LGTM. Couldn't it sit straight inside QtPageClient, though?
Simon Hausmann
Comment 3 2011-12-13 00:31:28 PST
Comment on attachment 118891 [details] Patch r=me, but we should get rid of our usage of QUndoStack in the future. It lives in QtWidgets and provides us with relatively little functionality that we use.
Caio Marcelo de Oliveira Filho
Comment 4 2011-12-13 02:25:07 PST
Committed r102666: <http://trac.webkit.org/changeset/102666>
Note You need to log in before you can comment on or make changes to this bug.