Bug 74360 – HTMLEmbedObject should match HTMLObjectElement by stopping any load when it is removed from beforeload

• Component: New Bugs
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

HTMLEmbedObject should match HTMLObjectElement by stopping any load when it is removed from beforeload

[Eric Seidel (no email)]

Created attachment 118882 [details]
Patch

[Eric Seidel (no email)]

http://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/beforeload/remove-flash-in-beforeload-listener.html was added by aestes.  CCing him and the reviewer ap in case they'd like to see this go by.

[Eric Seidel (no email)]

I suspect we should audit all callers to dispatchBeforeLoadEvent at some point. :)

[WebKit Review Bot]

Comment on attachment 118882 [details]
Patch

Rejecting attachment 118882 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ebCore/html/HTMLEmbedElement.cpp.rej
patching file Source/WebCore/html/HTMLObjectElement.cpp
Hunk #1 FAILED at 316.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/html/HTMLObjectElement.cpp.rej
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/fast/dom/beforeload/remove-flash-in-beforeload-listener.html

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/10845102

[Eric Seidel (no email)]

This patch depends on bug 74340.

[WebKit Review Bot]

Comment on attachment 118882 [details]
Patch

Rejecting attachment 118882 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ebCore/html/HTMLEmbedElement.cpp.rej
patching file Source/WebCore/html/HTMLObjectElement.cpp
Hunk #1 FAILED at 316.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/html/HTMLObjectElement.cpp.rej
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/fast/dom/beforeload/remove-flash-in-beforeload-listener.html

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/11349065

[Eric Seidel (no email)]

Comment on attachment 118882 [details]
Patch

This should be able to land now.  Sorry for the noise.

[Eric Seidel (no email)]

Comment on attachment 118882 [details]
Patch

Actually, nm.  Updating.

[Eric Seidel (no email)]

Created attachment 124026 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 124026 [details]
Patch for landing

Clearing flags on attachment: 124026

Committed r105938: <http://trac.webkit.org/changeset/105938>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.