Bug 74349

Summary: De-virtualize destructors part 5
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 74348    
Bug Blocks: 74331, 74350    
Attachments:
Description Flags
De-virtualize destructors part 5 ggaren: review+

Mark Hahnenberg
Reported 2011-12-12 14:56:38 PST
Same as bug 74341, just moving the static destroy functions down another level in the hierarchy and leaving behind any necessary destroy functions.
Attachments
De-virtualize destructors part 5 (18.65 KB, patch)
2011-12-12 15:03 PST, Mark Hahnenberg 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2011-12-12 15:03:41 PST
Created attachment 118869 [details] De-virtualize destructors part 5 No changelog (see bug 74331).
Geoffrey Garen
Comment 2 2011-12-12 15:32:33 PST
Comment on attachment 118869 [details] De-virtualize destructors part 5 View in context: https://bugs.webkit.org/attachment.cgi?id=118869&action=review r=me > Source/WebCore/bindings/js/JSDOMBinding.h:81 > + static JSC::Structure* createStructure(JSC::JSGlobalData& globalData, JSC::JSGlobalObject* globalObject, JSC::JSValue prototype) Your ChangeLog should explain why this is needed.
Note You need to log in before you can comment on or make changes to this bug.