Bug 74340

Summary: Share more code between updateWidget implementations in HTMLEmbedElement and HTMLObjectElement
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, dglazkov, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 47550    
Bug Blocks: 74360    
Attachments:
Description Flags
Patch
none
Patch for landing none

Eric Seidel (no email)
Reported 2011-12-12 14:33:48 PST
Share more code between updateWidget implementations in HTMLEmbedElement and HTMLObjectElement
Attachments
Patch (4.66 KB, patch)
2011-12-12 14:34 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.64 KB, patch)
2012-01-25 14:32 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-12-12 14:34:49 PST
Created attachment 118850 [details] Patch
Eric Seidel (no email)
Comment 2 2011-12-12 14:36:07 PST
I'm not sure whether this explicit "guarded" function is better, or use of a non-virtual override. Neither is particularly future-proof. At least this implementation should catch future callers trying to dispatch a beforeload event for one of these objects (at least until the dispatchBeforeLoadEvent signature changes on ContainerNode).
Adam Barth
Comment 3 2011-12-12 14:40:40 PST
Comment on attachment 118850 [details] Patch I'm not sure whether this will actually stop someone from write the wrong code, but I don't think it will cause that much confusion.
Eric Seidel (no email)
Comment 4 2011-12-12 14:43:51 PST
The relevant code was added in bug 47550. Unclear if it's still needed, or if this general recursion protection is needed for all objects which dispatch beforeload events.
WebKit Review Bot
Comment 5 2011-12-12 16:13:19 PST
Comment on attachment 118850 [details] Patch Attachment 118850 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10849103 New failing tests: fast/replaced/object-with-embed-url-param.html fast/replaced/object-param-spaces.html
Eric Seidel (no email)
Comment 6 2012-01-25 14:32:56 PST
Created attachment 124013 [details] Patch for landing
WebKit Review Bot
Comment 7 2012-01-25 15:30:12 PST
Comment on attachment 124013 [details] Patch for landing Clearing flags on attachment: 124013 Committed r105932: <http://trac.webkit.org/changeset/105932>
WebKit Review Bot
Comment 8 2012-01-25 15:30:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.