| Summary: | Share more code between updateWidget implementations in HTMLEmbedElement and HTMLObjectElement | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||
| Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, ap, dglazkov, simon.fraser, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 47550 | ||||||||
| Bug Blocks: | 74360 | ||||||||
| Attachments: |
|
||||||||
|
Description
Eric Seidel (no email)
2011-12-12 14:33:48 PST
Created attachment 118850 [details]
Patch
I'm not sure whether this explicit "guarded" function is better, or use of a non-virtual override. Neither is particularly future-proof. At least this implementation should catch future callers trying to dispatch a beforeload event for one of these objects (at least until the dispatchBeforeLoadEvent signature changes on ContainerNode). Comment on attachment 118850 [details]
Patch
I'm not sure whether this will actually stop someone from write the wrong code, but I don't think it will cause that much confusion.
The relevant code was added in bug 47550. Unclear if it's still needed, or if this general recursion protection is needed for all objects which dispatch beforeload events. Comment on attachment 118850 [details] Patch Attachment 118850 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10849103 New failing tests: fast/replaced/object-with-embed-url-param.html fast/replaced/object-param-spaces.html Created attachment 124013 [details]
Patch for landing
Comment on attachment 124013 [details] Patch for landing Clearing flags on attachment: 124013 Committed r105932: <http://trac.webkit.org/changeset/105932> All reviewed patches have been landed. Closing bug. |