Bug 74326

Summary: WebAudio: AudioBus::loadPlatformResource should mmap file on Mac port.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: Web AudioAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: crogers, darin, eric.carlson, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch darin: review+

Jer Noble
Reported 2011-12-12 13:38:49 PST
AudioBus::loadPlatformResource should mmap file on Mac port.
Attachments
Patch (2.00 KB, patch)
2011-12-12 13:42 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (2.00 KB, patch)
2011-12-12 15:57 PST, Jer Noble 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2011-12-12 13:42:40 PST
Created attachment 118836 [details] Patch
Jer Noble
Comment 2 2011-12-12 15:57:36 PST
Created attachment 118896 [details] Patch Rebased patch against ToT.
Jer Noble
Comment 3 2012-01-12 14:13:45 PST
Committed r104858: <http://trac.webkit.org/changeset/104858>
Ryosuke Niwa
Comment 4 2012-01-12 14:36:52 PST
This patch broke Snow Leopard builds. NSDataReadingMappedIfSafe isn't defined in 10.6 and earlier versions of Mac OS X.
Jer Noble
Comment 6 2012-01-12 14:51:36 PST
Fix coming.
Note You need to log in before you can comment on or make changes to this bug.