Bug 74326

Summary:

WebAudio: AudioBus::loadPlatformResource should mmap file on Mac port.

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

Web Audio

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

crogers, darin, eric.carlson, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	darin: review+

Description Jer Noble 2011-12-12 13:38:49 PST

AudioBus::loadPlatformResource should mmap file on Mac port.

Comment 1 Jer Noble 2011-12-12 13:42:40 PST

Created attachment 118836 [details]
Patch

Comment 2 Jer Noble 2011-12-12 15:57:36 PST

Created attachment 118896 [details]
Patch

Rebased patch against ToT.

Comment 3 Jer Noble 2012-01-12 14:13:45 PST

Committed r104858: <http://trac.webkit.org/changeset/104858>

Comment 4 Ryosuke Niwa 2012-01-12 14:36:52 PST

This patch broke Snow Leopard builds. NSDataReadingMappedIfSafe isn't defined in 10.6 and earlier versions of Mac OS X.

Comment 5 Ryosuke Niwa 2012-01-12 14:37:03 PST

http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Build%29/builds/37692/steps/compile-webkit/logs/stdio

Comment 6 Jer Noble 2012-01-12 14:51:36 PST

Fix coming.