|Summary:||prepare-ChangeLog should not include a reference file ('xxx-expected.html') used by reftests as a test file.|
|Product:||WebKit||Reporter:||Hayato Ito <hayato>|
|Component:||Tools / Tests||Assignee:||Hayato Ito <hayato>|
|Version:||528+ (Nightly build)|
Description Hayato Ito 2011-12-12 00:15:51 PST
If a change contains reftests, the output of prepare-changelog includes both a test file (xxx.html) and a reference file (xxx-expected.html) as follows: Tests: fast/dom/shadow/dynamically-created-shadow-root-expected.html fast/dom/shadow/dynamically-created-shadow-root.html: That should be: Tests: fast/dom/shadow/dynamically-created-shadow-root.html:
Comment 2 Ryosuke Niwa 2011-12-14 18:47:50 PST
Comment on attachment 118749 [details] exclude reffile View in context: https://bugs.webkit.org/attachment.cgi?id=118749&action=review > Tools/Scripts/prepare-ChangeLog:1619 > && !scalar(grep(/^resources$/i, @components)) This isn't going to work for -ref, -noref, ref-, etc... that are used by w3c reftests.
Comment 3 Hayato Ito 2011-12-14 19:24:06 PST
Thank you for the review. (In reply to comment #2) > (From update of attachment 118749 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=118749&action=review > > > Tools/Scripts/prepare-ChangeLog:1619 > > && !scalar(grep(/^resources$/i, @components)) > > This isn't going to work for -ref, -noref, ref-, etc... that are used by w3c reftests. Yeah, this is not perfect. But I'd like to delay handling such names as '-ref, -noref, etc' since there is no strict usable rule to detect these names in easy way. It might be better to file another bug to handle such cases. As for '-expected.html' and '-expected-mismatch.html', this is clear and present issue. So this must be fixed. Later we might have to handle such cases, '-ref, ...etc'.
Comment 4 Hayato Ito 2011-12-14 19:42:26 PST
I've filed another bug in https://bugs.webkit.org/show_bug.cgi?id=74579.
Comment 6 WebKit Review Bot 2012-05-06 23:52:04 PDT
Comment on attachment 140481 [details] Patch for landing Clearing flags on attachment: 140481 Committed r116279: <http://trac.webkit.org/changeset/116279>
Comment 7 WebKit Review Bot 2012-05-06 23:52:09 PDT
All reviewed patches have been landed. Closing bug.