Bug 74247

Summary: Web Inspector: [protocol] alter some type names generated from Inspector.json
Product: WebKit Reporter: Peter Rybin <peter.rybin>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, peter.rybin, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Peter Rybin
Reported 2011-12-10 16:17:06 PST
CodeGeneratorInspector.py takes type names straight from Inspector.json. However it should be more careful with some of them because they may conflict with already existing names (notable defines that are namespace-agnostic). See commend about RGBA in https://bugs.webkit.org/show_bug.cgi?id=72835
Attachments
Patch (5.79 KB, patch)
2011-12-10 16:30 PST, Peter Rybin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Peter Rybin
Comment 1 2011-12-10 16:30:07 PST
Created attachment 118697 [details] Patch
Ilya Tikhonovsky
Comment 2 2011-12-11 12:44:44 PST
Comment on attachment 118697 [details] Patch Clearing flags on attachment: 118697 Committed r102541: <http://trac.webkit.org/changeset/102541>
Ilya Tikhonovsky
Comment 3 2011-12-11 12:44:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.