| Summary: | v8 benchmark takes 12-13 million function call slow paths due to extra arguments | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Geoffrey Garen <ggaren> | ||||
| Component: | New Bugs | Assignee: | Geoffrey Garen <ggaren> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | ||||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Geoffrey Garen
2011-12-10 15:20:12 PST
Created attachment 118713 [details]
Patch
Comment on attachment 118713 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118713&action=review r=me, though it would be good to verify kraken + sunspider are okay > Source/JavaScriptCore/interpreter/Interpreter.h:88 > - enum { MaxLargeThreadReentryDepth = 93, MaxSmallThreadReentryDepth = 32 }; > + enum { MaxLargeThreadReentryDepth = 93, MaxSmallThreadReentryDepth = 16 }; > #else > - enum { MaxLargeThreadReentryDepth = 256, MaxSmallThreadReentryDepth = 32 }; > + enum { MaxLargeThreadReentryDepth = 256, MaxSmallThreadReentryDepth = 16 }; Sadness -- we really should switch to stack size limits rather than reentry shenanigans :-/ > r=me, though it would be good to verify kraken + sunspider are okay Neutral on Kraken+SunSpider. > Sadness -- we really should switch to stack size limits rather than reentry shenanigans :-/ Yeah. I think we should also find the giant object(s) we're putting on the stack and put them on the heap instead. Committed r102545: <http://trac.webkit.org/changeset/102545> |