Bug 74244 – v8 benchmark takes 12-13 million function call slow paths due to extra arguments

• Component: New Bugs
• Status: RESOLVED FIXED

[Geoffrey Garen]

v8 benchmark takes 12-13 million function call slow paths due to extra arguments

[Geoffrey Garen]

Created attachment 118713 [details]
Patch

[Oliver Hunt]

Comment on attachment 118713 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118713&action=review

r=me, though it would be good to verify kraken + sunspider are okay

> Source/JavaScriptCore/interpreter/Interpreter.h:88
> -    enum { MaxLargeThreadReentryDepth = 93, MaxSmallThreadReentryDepth = 32 };
> +    enum { MaxLargeThreadReentryDepth = 93, MaxSmallThreadReentryDepth = 16 };
>  #else
> -    enum { MaxLargeThreadReentryDepth = 256, MaxSmallThreadReentryDepth = 32 };
> +    enum { MaxLargeThreadReentryDepth = 256, MaxSmallThreadReentryDepth = 16 };

Sadness -- we really should switch to stack size limits rather than reentry shenanigans :-/

[Geoffrey Garen]

> r=me, though it would be good to verify kraken + sunspider are okay

Neutral on Kraken+SunSpider.

> Sadness -- we really should switch to stack size limits rather than reentry shenanigans :-/

Yeah. I think we should also find the giant object(s) we're putting on the stack and put them on the heap instead.

[Geoffrey Garen]

Committed r102545: <http://trac.webkit.org/changeset/102545>