Summary: | V8Proxy cleanup: replace custom logging methods with standard WebCore calls | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Klein <adamk> | ||||||||
Component: | New Bugs | Assignee: | Adam Klein <adamk> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, arv, japhet, kbr, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Adam Klein
2011-12-09 14:44:53 PST
Created attachment 118645 [details]
Patch
Created attachment 118653 [details]
Update test expectations
Comment on attachment 118653 [details] Update test expectations View in context: https://bugs.webkit.org/attachment.cgi?id=118653&action=review > LayoutTests/fast/xpath/nsresolver-bad-object-expected.txt:1 > -CONSOLE MESSAGE: line 0: XPathNSResolver does not have a lookupNamespaceURI method. > +CONSOLE MESSAGE: line 1: XPathNSResolver does not have a lookupNamespaceURI method. Is this going to cause a problem for JSC ports? (In reply to comment #3) > (From update of attachment 118653 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=118653&action=review > > > LayoutTests/fast/xpath/nsresolver-bad-object-expected.txt:1 > > -CONSOLE MESSAGE: line 0: XPathNSResolver does not have a lookupNamespaceURI method. > > +CONSOLE MESSAGE: line 1: XPathNSResolver does not have a lookupNamespaceURI method. > > Is this going to cause a problem for JSC ports? Arg....probably? Guess I'll have to fix this code to pass 0 in. Created attachment 118925 [details]
Patch for landing
Comment on attachment 118925 [details] Patch for landing Rejecting attachment 118925 [details] from commit-queue. New failing tests: http/tests/inspector/resource-tree/resource-tree-document-url.html Full output: http://queues.webkit.org/results/10847197 Comment on attachment 118925 [details]
Patch for landing
Test failure looked like a flake, trying again.
Comment on attachment 118925 [details] Patch for landing Clearing flags on attachment: 118925 Committed r102688: <http://trac.webkit.org/changeset/102688> All reviewed patches have been landed. Closing bug. Reverted r102688 for reason: Under the hypothesis that it might be the cause of browser_tests and ui_tests crashes on Chromium canaries -- will reland if not. Committed r102794: <http://trac.webkit.org/changeset/102794> Reverted r102794 for reason: Reapplying patch since it is not the cause of the problems described in bug 74220. Committed r102871: <http://trac.webkit.org/changeset/102871> |