Bug 74220

Summary: V8Proxy cleanup: replace custom logging methods with standard WebCore calls
Product: WebKit Reporter: Adam Klein <adamk>
Component: New BugsAssignee: Adam Klein <adamk>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, arv, japhet, kbr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Update test expectations
none
Patch for landing none

Adam Klein
Reported 2011-12-09 14:44:53 PST
V8Proxy cleanup: replace custom logging methods with standard WebCore calls
Attachments
Patch (5.49 KB, patch)
2011-12-09 14:45 PST, Adam Klein 		no flags
DetailsFormatted DiffDiff
Update test expectations (6.69 KB, patch)
2011-12-09 15:10 PST, Adam Klein 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.43 KB, patch)
2011-12-12 17:50 PST, Adam Klein 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Klein
Comment 1 2011-12-09 14:45:16 PST
Created attachment 118645 [details] Patch
Adam Klein
Comment 2 2011-12-09 15:10:40 PST
Created attachment 118653 [details] Update test expectations
Adam Barth
Comment 3 2011-12-12 16:43:28 PST
Comment on attachment 118653 [details] Update test expectations View in context: https://bugs.webkit.org/attachment.cgi?id=118653&action=review > LayoutTests/fast/xpath/nsresolver-bad-object-expected.txt:1 > -CONSOLE MESSAGE: line 0: XPathNSResolver does not have a lookupNamespaceURI method. > +CONSOLE MESSAGE: line 1: XPathNSResolver does not have a lookupNamespaceURI method. Is this going to cause a problem for JSC ports?
Adam Klein
Comment 4 2011-12-12 16:55:15 PST
(In reply to comment #3) > (From update of attachment 118653 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=118653&action=review > > > LayoutTests/fast/xpath/nsresolver-bad-object-expected.txt:1 > > -CONSOLE MESSAGE: line 0: XPathNSResolver does not have a lookupNamespaceURI method. > > +CONSOLE MESSAGE: line 1: XPathNSResolver does not have a lookupNamespaceURI method. > > Is this going to cause a problem for JSC ports? Arg....probably? Guess I'll have to fix this code to pass 0 in.
Adam Klein
Comment 5 2011-12-12 17:50:30 PST
Created attachment 118925 [details] Patch for landing
WebKit Review Bot
Comment 6 2011-12-12 19:33:26 PST
Comment on attachment 118925 [details] Patch for landing Rejecting attachment 118925 [details] from commit-queue. New failing tests: http/tests/inspector/resource-tree/resource-tree-document-url.html Full output: http://queues.webkit.org/results/10847197
Adam Klein
Comment 7 2011-12-13 08:56:04 PST
Comment on attachment 118925 [details] Patch for landing Test failure looked like a flake, trying again.
WebKit Review Bot
Comment 8 2011-12-13 10:20:38 PST
Comment on attachment 118925 [details] Patch for landing Clearing flags on attachment: 118925 Committed r102688: <http://trac.webkit.org/changeset/102688>
WebKit Review Bot
Comment 9 2011-12-13 10:20:43 PST
All reviewed patches have been landed. Closing bug.
Kenneth Russell
Comment 10 2011-12-14 10:03:49 PST
Reverted r102688 for reason: Under the hypothesis that it might be the cause of browser_tests and ui_tests crashes on Chromium canaries -- will reland if not. Committed r102794: <http://trac.webkit.org/changeset/102794>
Kenneth Russell
Comment 11 2011-12-14 19:22:13 PST
Reverted r102794 for reason: Reapplying patch since it is not the cause of the problems described in bug 74220. Committed r102871: <http://trac.webkit.org/changeset/102871>
Note You need to log in before you can comment on or make changes to this bug.